Bug 104120 - [Qt] Fix the build if the path contains "+" character
Summary: [Qt] Fix the build if the path contains "+" character
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-12-05 07:20 PST by Csaba Osztrogonác
Modified: 2012-12-06 05:56 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.25 KB, patch)
2012-12-05 07:43 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (3.87 KB, patch)
2012-12-06 05:28 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-12-05 07:20:25 PST
Debian/Ubuntu package names usually contain "+" character
and now the build is broken if the path contain any plus.

Patch is coming soon.
Comment 1 Csaba Osztrogonác 2012-12-05 07:43:07 PST
Created attachment 177746 [details]
Patch
Comment 2 Simon Hausmann 2012-12-05 09:19:51 PST
Comment on attachment 177746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177746&action=review

> Tools/qmake/mkspecs/features/functions.prf:29
> +defineReplace(toEscapedStringForRegexp) {
> +    return($$replace(1, \+, \+))
> +}

I thought that there was a qmake function for that. Ah yes, can you try $$re_escape?
Comment 3 Csaba Osztrogonác 2012-12-05 09:22:15 PST
I din't know if it exists, I'm going to check and use this re_escape.
Comment 4 Csaba Osztrogonác 2012-12-06 05:28:08 PST
Created attachment 178000 [details]
Patch
Comment 5 Tor Arne Vestbø 2012-12-06 05:37:11 PST
Comment on attachment 178000 [details]
Patch

lgtm
Comment 6 WebKit Review Bot 2012-12-06 05:56:49 PST
Comment on attachment 178000 [details]
Patch

Clearing flags on attachment: 178000

Committed r136836: <http://trac.webkit.org/changeset/136836>
Comment 7 WebKit Review Bot 2012-12-06 05:56:53 PST
All reviewed patches have been landed.  Closing bug.