Bug 104112 - Use always the order iterator from data member in RenderFlexibleBox
Summary: Use always the order iterator from data member in RenderFlexibleBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 104109
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-05 04:09 PST by Carlos Garcia Campos
Modified: 2012-12-07 05:58 PST (History)
3 users (show)

See Also:


Attachments
Patch (15.13 KB, patch)
2012-12-05 04:14 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-12-05 04:09:57 PST
Some methods receive it as parameter and others use the data member.
Comment 1 Carlos Garcia Campos 2012-12-05 04:14:18 PST
Created attachment 177724 [details]
Patch
Comment 2 Carlos Garcia Campos 2012-12-05 04:14:52 PST
This patch applies on top of patch attached to bug #104109
Comment 3 Tony Chang 2012-12-05 12:12:26 PST
Comment on attachment 177724 [details]
Patch

We should also consider making m_orderIterator stack allocated.  We would have to adjust how we initialize it.
Comment 4 Carlos Garcia Campos 2012-12-07 01:59:03 PST
Comment on attachment 177724 [details]
Patch

Committed r136938 <http://trac.webkit.org/changeset/136938>
Comment 5 Carlos Garcia Campos 2012-12-07 05:58:16 PST
(In reply to comment #3)
> (From update of attachment 177724 [details])
> We should also consider making m_orderIterator stack allocated.  We would have to adjust how we initialize it.

Yes, and we also need to make some methods that use the iterator non-const, see:

https://bugs.webkit.org/show_bug.cgi?id=104366