WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104112
Use always the order iterator from data member in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=104112
Summary
Use always the order iterator from data member in RenderFlexibleBox
Carlos Garcia Campos
Reported
2012-12-05 04:09:57 PST
Some methods receive it as parameter and others use the data member.
Attachments
Patch
(15.13 KB, patch)
2012-12-05 04:14 PST
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2012-12-05 04:14:18 PST
Created
attachment 177724
[details]
Patch
Carlos Garcia Campos
Comment 2
2012-12-05 04:14:52 PST
This patch applies on top of patch attached to
bug #104109
Tony Chang
Comment 3
2012-12-05 12:12:26 PST
Comment on
attachment 177724
[details]
Patch We should also consider making m_orderIterator stack allocated. We would have to adjust how we initialize it.
Carlos Garcia Campos
Comment 4
2012-12-07 01:59:03 PST
Comment on
attachment 177724
[details]
Patch Committed
r136938
<
http://trac.webkit.org/changeset/136938
>
Carlos Garcia Campos
Comment 5
2012-12-07 05:58:16 PST
(In reply to
comment #3
)
> (From update of
attachment 177724
[details]
) > We should also consider making m_orderIterator stack allocated. We would have to adjust how we initialize it.
Yes, and we also need to make some methods that use the iterator non-const, see:
https://bugs.webkit.org/show_bug.cgi?id=104366
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug