WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104108
Web Inspector: Title of "Record Timeline" status button on "Timeline Panel" should reflect the recording state
https://bugs.webkit.org/show_bug.cgi?id=104108
Summary
Web Inspector: Title of "Record Timeline" status button on "Timeline Panel" s...
Sankeerth V S
Reported
2012-12-05 03:23:49 PST
Title of "Record Timeline" status button on "Timeline Panel" should be toggled upon the recording state.
Attachments
Patch
(1.94 KB, patch)
2012-12-05 03:37 PST
,
Sankeerth V S
no flags
Details
Formatted Diff
Diff
Patch
(1.92 KB, patch)
2012-12-05 22:39 PST
,
Sankeerth V S
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sankeerth V S
Comment 1
2012-12-05 03:25:15 PST
patch to follow.
Sankeerth V S
Comment 2
2012-12-05 03:37:44 PST
Created
attachment 177715
[details]
Patch
Alexander Pavlov (apavlov)
Comment 3
2012-12-05 04:17:00 PST
Comment on
attachment 177715
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=177715&action=review
> Source/WebCore/ChangeLog:4 > + Panel" should be toggled upon the recording state.
I'd put it as "...should reflect the recording state."
> Source/WebCore/inspector/front-end/TimelinePanel.js:556 > + this.toggleTimelineButton.title = WebInspector.UIString("Stop");
The previous line looks like a more appropriate place for this line, since starting the record and toggling the title are logically related, and sending the metrics event is related to the entire sequence.
Sankeerth V S
Comment 4
2012-12-05 22:39:06 PST
Created
attachment 177940
[details]
Patch
WebKit Review Bot
Comment 5
2012-12-05 23:29:01 PST
Comment on
attachment 177940
[details]
Patch Clearing flags on attachment: 177940 Committed
r136809
: <
http://trac.webkit.org/changeset/136809
>
WebKit Review Bot
Comment 6
2012-12-05 23:29:04 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug