RESOLVED FIXED 104082
[V8] Replace String::New("symbol") with String::NewSymbol("symbol") (part 2) 
https://bugs.webkit.org/show_bug.cgi?id=104082
Summary [V8] Replace String::New("symbol") with String::NewSymbol("symbol") (part 2)
Kentaro Hara
Reported 2012-12-04 21:01:33 PST
V8 can look up symbols faster than strings.
Attachments
Patch (11.64 KB, patch)
2012-12-04 21:03 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-04 21:03:24 PST
Created attachment 177661 [details] Patch
Adam Barth
Comment 2 2012-12-04 21:07:10 PST
Comment on attachment 177661 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177661&action=review > Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:40 > + v8::Handle<v8::String> key = v8::String::NewSymbol(hiddenCopyMethodName); What is hiddenCopyMethodName all about? Why doesn't this just use V8HiddenValueNames?
Adam Barth
Comment 3 2012-12-04 21:08:04 PST
@haraken: Would you be willing to make a followup patch to switch from the ad-hoc constant to V8HiddenPropertyName?
Kentaro Hara
Comment 4 2012-12-04 21:08:29 PST
(In reply to comment #3) > @haraken: Would you be willing to make a followup patch to switch from the ad-hoc constant to V8HiddenPropertyName? Sure!
WebKit Review Bot
Comment 5 2012-12-05 00:02:27 PST
Comment on attachment 177661 [details] Patch Clearing flags on attachment: 177661 Committed r136645: <http://trac.webkit.org/changeset/136645>
WebKit Review Bot
Comment 6 2012-12-05 00:02:32 PST
All reviewed patches have been landed. Closing bug.
Kenneth Russell
Comment 7 2012-12-05 11:40:44 PST
Ulan added the optimization to ArrayBufferView; while I reviewed it, I didn't know about V8HiddenPropertyName. Sorry about that.
Note You need to log in before you can comment on or make changes to this bug.