inspector/profiler/cpu-profiler-profiling-without-inspector.html currently does not provide enough coverage for v8's sampling profiler, as it immediately stops profiling after starting it (this is covered by a separate, and, apparently, redundant branch of code in v8's CPU profiler). We should run test for an extended time to assure sampling profiler works.
Created attachment 177624 [details] Patch
Comment on attachment 177624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177624&action=review > LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html:78 > + const roundingThreshold = 50; // Time should be good within 50ms This will be flaky. You should test that the (actualValue > expectedValue - 50).
Created attachment 177823 [details] Patch
Comment on attachment 177823 [details] Patch Attachment 177823 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15138847 New failing tests: inspector/profiler/cpu-profiler-profiling-without-inspector.html
Created attachment 178046 [details] Patch
Comment on attachment 178046 [details] Patch Attachment 178046 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15170648 New failing tests: inspector/profiler/cpu-profiler-profiling-without-inspector.html
Comment on attachment 178046 [details] Patch Attachment 178046 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15188210 New failing tests: inspector/profiler/cpu-profiler-profiling-without-inspector.html
Comment on attachment 178046 [details] Patch It is already flaky on the try bots.
Created attachment 178519 [details] Patch
(In reply to comment #8) > (From update of attachment 178046 [details]) > It is already flaky on the try bots. It's not falky, these were genuine faults unrelated to timing -- the line numbers were wrong. Sorry about that, got a wrong expectation uploaded in a hurry. I've fixed that and a side effect that caused cpu-profiler-profiling.html to fail.
Committed r137266: <http://trac.webkit.org/changeset/137266>
Reverted r137266 for reason: New test fails on WebKit Win7 and chromium mac Committed r137276: <http://trac.webkit.org/changeset/137276>
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.