Bug 104068 - Remove gyp config for incomplete and unused Apple Mac gyp build
Summary: Remove gyp config for incomplete and unused Apple Mac gyp build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-04 17:21 PST by Adam Klein
Modified: 2012-12-06 11:34 PST (History)
3 users (show)

See Also:


Attachments
Patch (37.84 KB, patch)
2012-12-04 17:21 PST, Adam Klein
no flags Details | Formatted Diff | Diff
Patch (42.44 KB, patch)
2012-12-04 18:04 PST, Adam Klein
no flags Details | Formatted Diff | Diff
Patch (42.48 KB, patch)
2012-12-05 09:50 PST, Adam Klein
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-12-04 17:21:07 PST
Remove gyp config for incomplete and unused Apple Mac gyp build
Comment 1 Adam Klein 2012-12-04 17:21:20 PST
Created attachment 177614 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-04 17:46:52 PST
Comment on attachment 177614 [details]
Patch

Attachment 177614 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15147249
Comment 3 Adam Klein 2012-12-04 18:04:54 PST
Created attachment 177634 [details]
Patch
Comment 4 Adam Klein 2012-12-05 09:50:18 PST
Created attachment 177784 [details]
Patch
Comment 5 Adam Klein 2012-12-05 09:50:48 PST
Ready for review (and merged to trunk)
Comment 6 WebKit Review Bot 2012-12-05 18:19:04 PST
Comment on attachment 177784 [details]
Patch

Rejecting attachment 177784 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ebCore.gypi
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 2733 (offset 1 line).
Hunk #3 succeeded at 2999 (offset 1 line).
Hunk #4 succeeded at 3773 (offset -1 lines).
Hunk #7 succeeded at 5289 (offset -4 lines).
Hunk #8 succeeded at 5350 (offset -4 lines).
1 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.gypi.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15175041
Comment 7 Adam Klein 2012-12-06 11:34:26 PST
Committed r136862: <http://trac.webkit.org/changeset/136862>