Bug 104061 - nrwt: fix total number of tests computed in the result summary
Summary: nrwt: fix total number of tests computed in the result summary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 103824
  Show dependency treegraph
 
Reported: 2012-12-04 16:40 PST by Dirk Pranke
Modified: 2012-12-10 15:12 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.10 KB, patch)
2012-12-04 16:43 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2012-12-05 19:15 PST, Dirk Pranke
jochen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-04 16:40:47 PST
nrwt: fix total number of tests computed in the result summary
Comment 1 Dirk Pranke 2012-12-04 16:43:32 PST
Created attachment 177604 [details]
Patch
Comment 2 Dirk Pranke 2012-12-04 16:44:05 PST
Committed r136593: <http://trac.webkit.org/changeset/136593>
Comment 3 Dirk Pranke 2012-12-04 16:44:30 PST
re-opening to ensure that the unit test is written for this.
Comment 4 Dirk Pranke 2012-12-04 16:45:42 PST
reopening to ensure that a test gets written.
Comment 5 Dirk Pranke 2012-12-04 16:47:00 PST
should also write a test to ensure that the statistics for test run time and test total time are correct as discussed in bug 103943.
Comment 6 Dirk Pranke 2012-12-05 19:15:05 PST
Created attachment 177910 [details]
Patch
Comment 7 jochen 2012-12-10 06:31:33 PST
Comment on attachment 177910 [details]
Patch

I ran into the same problem, and after a bit of debugging came to the same fix.

I verified that your patch indeed fixes the problem, so lgtm
Comment 8 Dirk Pranke 2012-12-10 10:59:43 PST
Committed r137183: <http://trac.webkit.org/changeset/137183>