nrwt: remove two unused parameters from a function
Created attachment 177598 [details] Patch
Comment on attachment 177598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177598&action=review > Tools/ChangeLog:3 > + nrwt: remove two unused parameters from a function It would have been better if this bug title referred to interpret_test_failures. > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:60 > """Interpret test failures and returns a test result as dict. You might as well as delete this block comment. It refers to parameters you’re deleting this patch. And comments like: " Args: failures: list of test failures Returns: A dictionary like {'is_missing_text': True, …}" doesn’t add much value beyond the code beneath it.
Comment on attachment 177598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177598&action=review >> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:60 >> """Interpret test failures and returns a test result as dict. > > You might as well as delete this block comment. It refers to parameters you’re deleting this patch. > And comments like: > " Args: > failures: list of test failures > Returns: > A dictionary like {'is_missing_text': True, …}" > doesn’t add much value beyond the code beneath it. Ah, you're right. Will do.
Committed r136732: <http://trac.webkit.org/changeset/136732>