WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104059
nrwt: remove two unused parameters from a function
https://bugs.webkit.org/show_bug.cgi?id=104059
Summary
nrwt: remove two unused parameters from a function
Dirk Pranke
Reported
2012-12-04 16:20:51 PST
nrwt: remove two unused parameters from a function
Attachments
Patch
(4.98 KB, patch)
2012-12-04 16:21 PST
,
Dirk Pranke
rniwa
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-12-04 16:21:17 PST
Created
attachment 177598
[details]
Patch
Ryosuke Niwa
Comment 2
2012-12-04 17:45:28 PST
Comment on
attachment 177598
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=177598&action=review
> Tools/ChangeLog:3 > + nrwt: remove two unused parameters from a function
It would have been better if this bug title referred to interpret_test_failures.
> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:60 > """Interpret test failures and returns a test result as dict.
You might as well as delete this block comment. It refers to parameters you’re deleting this patch. And comments like: " Args: failures: list of test failures Returns: A dictionary like {'is_missing_text': True, …}" doesn’t add much value beyond the code beneath it.
Dirk Pranke
Comment 3
2012-12-04 17:55:35 PST
Comment on
attachment 177598
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=177598&action=review
>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:60 >> """Interpret test failures and returns a test result as dict. > > You might as well as delete this block comment. It refers to parameters you’re deleting this patch. > And comments like: > " Args: > failures: list of test failures > Returns: > A dictionary like {'is_missing_text': True, …}" > doesn’t add much value beyond the code beneath it.
Ah, you're right. Will do.
Dirk Pranke
Comment 4
2012-12-05 12:23:12 PST
Committed
r136732
: <
http://trac.webkit.org/changeset/136732
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug