Bug 104054 - svg/custom/use-href-update-crash.svg failing on certain platforms
Summary: svg/custom/use-href-update-crash.svg failing on certain platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-04 15:25 PST by Florin Malita
Modified: 2013-08-08 11:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.79 KB, patch)
2013-08-08 08:20 PDT, Rob Buis
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2012-12-04 15:25:30 PST
Apple/Mac
Apple/Win
Qt/Linux

CONSOLE MESSAGE: line 12: ReferenceError: Can't find variable: gc
layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
  RenderSVGRoot {svg} at (0,0) size 127x4
    RenderSVGText {text} at (0,-15) size 127x19 contains 1 chunk(s)
      RenderSVGInlineText {#text} at (0,0) size 127x19
        chunk 1 text run 1 at (0.00,0.00) startOffset 0 endOffset 20 width 127.00: "PASS: did not crash."

Not sure why the gc() call is undefined on these, I'll suppress the test for now.
Comment 1 Abhishek Arya 2012-12-04 15:28:41 PST
Florin, you need to include gc() from js-test-pre.js. It is not defined on all platforms.
Comment 2 Florin Malita 2012-12-04 15:31:04 PST
(In reply to comment #1)
> Florin, you need to include gc() from js-test-pre.js. It is not defined on all platforms.

I see, thanks! I figured I must be missing something :)
Comment 3 Florin Malita 2012-12-04 15:51:21 PST
http://trac.webkit.org/changeset/136586
Comment 4 Florin Malita 2012-12-04 17:41:47 PST
Gah, still failing. Marking as such on Mac & Qt to clear the bots:

http://trac.webkit.org/changeset/136604
Comment 5 Roger Fong 2012-12-04 18:05:59 PST
(In reply to comment #4)
> Gah, still failing. Marking as such on Mac & Qt to clear the bots:
> 
> http://trac.webkit.org/changeset/136604

Please skip on Windows Port as well.

platform/win/TestExpectations

Thanks
Comment 6 Florin Malita 2012-12-04 19:27:14 PST
(In reply to comment #5)
> (In reply to comment #4)
> > Gah, still failing. Marking as such on Mac & Qt to clear the bots:
> > 
> > http://trac.webkit.org/changeset/136604
> 
> Please skip on Windows Port as well.
> 
> platform/win/TestExpectations
> 
> Thanks

Done: http://trac.webkit.org/changeset/136610
Comment 7 Rob Buis 2013-08-08 08:20:09 PDT
Created attachment 208346 [details]
Patch
Comment 8 Rob Buis 2013-08-08 11:19:37 PDT
Committed r153833: <http://trac.webkit.org/changeset/153833>