Bug 104042 – REGRESSION(r135082): Restore the ability to insert author level style sheets from script

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Tony Chang]

Chromium's extension API has a method for inserting a stylesheet from script.  We were using DocumentStyleSheetCollection::addUserSheet, but trying to add an author level stylesheet.  This broke in r135082, which seems OK since it using the API in an unintended way.

I'll upload a patch that adds a real method for adding author level stylesheets from script.

[Tony Chang]

Created attachment 177558 [details]
Patch

[Tony Chang]

The upstream bug tracking this is https://code.google.com/p/chromium/issues/detail?id=163445 .

antti or kling, can you review?

[Build Bot]

Comment on attachment 177558 [details]
Patch

Attachment 177558 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15132618

[Build Bot]

Comment on attachment 177558 [details]
Patch

Attachment 177558 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15121922

[Tony Chang]

Created attachment 177590 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 177590 [details]
Patch

Attachment 177590 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15157132

[Antti Koivisto]

Can't you use the existing PageGroup::addUserStyleSheetToWorld mechanism? Despite its name it supports inserting both user and author level stylesheets.

[Tony Chang]

(In reply to comment #7)
> Can't you use the existing PageGroup::addUserStyleSheetToWorld mechanism? Despite its name it supports inserting both user and author level stylesheets.

This is different from adding to a PageGroup since it's done from script.  E.g., if the user reloads the page, the style shouldn't automatically be re-inserted.  The PageGroup methods seem designed more for automatic insertion based on a URL pattern at fixed time periods.

[Tony Chang]

Created attachment 177805 [details]
Patch

[Build Bot]

Comment on attachment 177805 [details]
Patch

Attachment 177805 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15153543

[Tony Chang]

Created attachment 177846 [details]
Patch

[Build Bot]

Comment on attachment 177846 [details]
Patch

Attachment 177846 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15158518

[Tony Chang]

Comment on attachment 177846 [details]
Patch

The win bot failure should have been fixed by https://bugs.webkit.org/show_bug.cgi?id=104136 .

[WebKit Review Bot]

Comment on attachment 177846 [details]
Patch

Rejecting attachment 177846 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
-queue/Source/WebKit/chromium/tools/xdisplaycheck --revision 171376 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 171376.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15185065

[Tony Chang]

Created attachment 178053 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 178053 [details]
Patch for landing

Rejecting attachment 178053 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 167605 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 167605.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15173471

[Tony Chang]

Created attachment 178062 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 178062 [details]
Patch for landing

Clearing flags on attachment: 178062

Committed r136878: <http://trac.webkit.org/changeset/136878>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.