Bug 104039 – Web Inspector: Keep LiveEdit API disabled when idle

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

LiveEdit is a sophisticated routine in V8, and potentially it may have some vulnerabilities. Enable C-level blocks in V8 core, that won't allow LiveEdit code unless actually called LiveEdit command.

Related Chromium bug: https://code.google.com/p/chromium/issues/detail?id=159124

[Peter Rybin]

Created attachment 178444 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 178444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178444&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:318
> +        EnableLiveEditScope() { v8::Debug::SetLiveEditEnabled(true); }

Can it happen that LiveEdit is already on and will be turned off when the scope is destroyed?

[Peter Rybin]

(In reply to comment #2)
> (From update of attachment 178444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178444&action=review
> 
> > Source/WebCore/bindings/v8/ScriptDebugServer.cpp:318
> > +        EnableLiveEditScope() { v8::Debug::SetLiveEditEnabled(true); }
> 
> Can it happen that LiveEdit is already on and will be turned off when the scope is destroyed?

That's possibly, but shouldn't be considered a problem I think.
The V8 API is not fully accurate here, because it should also provide getter. However I think we assume the only mode currently: LiveEdit is disabled all the time except when needed.

[WebKit Review Bot]

Comment on attachment 178444 [details]
Patch

Clearing flags on attachment: 178444

Committed r138442: <http://trac.webkit.org/changeset/138442>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.