Bug 104028 - Web Inspector: simplify reportMemoryUsage signature
Summary: Web Inspector: simplify reportMemoryUsage signature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on: 104065
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-04 12:37 PST by Yury Semikhatsky
Modified: 2012-12-04 18:41 PST (History)
12 users (show)

See Also:

Attachments
Patch (20.88 KB, patch)
2012-12-04 14:10 PST, Yury Semikhatsky 		vsevik: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (21.01 KB, patch)
2012-12-04 18:28 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-12-04 12:37:06 PST 
There are lots of places where parameters have unnecessary "const&" modifier.
Comment 1 Yury Semikhatsky 2012-12-04 14:10:38 PST 
Created attachment 177555 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-12-04 14:15:23 PST 
Comment on attachment 177555 [details]
Patch

lgtm
Comment 3 Build Bot 2012-12-04 15:19:06 PST 
Comment on attachment 177555 [details]
Patch

Attachment 177555 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15144209
Comment 4 Yury Semikhatsky 2012-12-04 16:57:39 PST 
Committed r136597: <http://trac.webkit.org/changeset/136597>
Comment 5 WebKit Review Bot 2012-12-04 17:09:13 PST 
Re-opened since this is blocked by bug 104065
Comment 6 Yury Semikhatsky 2012-12-04 18:28:31 PST 
Created attachment 177638 [details]
Patch for landing
Comment 7 Yury Semikhatsky 2012-12-04 18:41:31 PST 
Committed r136608: <http://trac.webkit.org/changeset/136608>