Bug 104026 - Web Inspector: Native Memory Instrumentation: instrument RenderBox descendants.
Summary: Web Inspector: Native Memory Instrumentation: instrument RenderBox descendants.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on: 103564
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-04 12:16 PST by Ilya Tikhonovsky
Modified: 2012-12-10 09:33 PST (History)
17 users (show)

See Also:


Attachments
followup patch. It cannot be compiled without wk-bug 103564. (12.66 KB, patch)
2012-12-04 12:26 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
rebaselined (13.44 KB, patch)
2012-12-10 07:18 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
rebaselined (12.62 KB, patch)
2012-12-10 07:19 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-12-04 12:16:47 PST
RenderReplica
RenderTableCol
RenderTableRow
RenderReplaced
RenderFrameSet
RenderTableSection
RenderListMarker

RenderBlock has been instrumented in WK-BUG 103564
Comment 1 Ilya Tikhonovsky 2012-12-04 12:26:24 PST
Created attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.
Comment 2 Early Warning System Bot 2012-12-04 12:34:33 PST
Comment on attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.

Attachment 177527 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15121880
Comment 3 Early Warning System Bot 2012-12-04 12:35:44 PST
Comment on attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.

Attachment 177527 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15152070
Comment 4 EFL EWS Bot 2012-12-04 12:41:53 PST
Comment on attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.

Attachment 177527 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15133517
Comment 5 Build Bot 2012-12-04 12:42:12 PST
Comment on attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.

Attachment 177527 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15119921
Comment 6 Build Bot 2012-12-04 13:04:03 PST
Comment on attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.

Attachment 177527 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15126737
Comment 7 WebKit Review Bot 2012-12-04 13:08:16 PST
Comment on attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.

Attachment 177527 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15133520
Comment 8 Peter Beverloo (cr-android ews) 2012-12-04 15:27:59 PST
Comment on attachment 177527 [details]
followup patch. It cannot be compiled without wk-bug 103564.

Attachment 177527 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15151191
Comment 9 Ilya Tikhonovsky 2012-12-10 07:18:42 PST
Created attachment 178545 [details]
rebaselined
Comment 10 Ilya Tikhonovsky 2012-12-10 07:19:33 PST
Created attachment 178546 [details]
rebaselined
Comment 11 Eric Seidel (no email) 2012-12-10 09:25:10 PST
Comment on attachment 178546 [details]
rebaselined

Looks reasonable.
Comment 12 WebKit Review Bot 2012-12-10 09:33:33 PST
Comment on attachment 178546 [details]
rebaselined

Clearing flags on attachment: 178546

Committed r137169: <http://trac.webkit.org/changeset/137169>
Comment 13 WebKit Review Bot 2012-12-10 09:33:38 PST
All reviewed patches have been landed.  Closing bug.