Bug 104019 - [BlackBerry] Avoid showing FCC on empty text field in a different way
Summary: [BlackBerry] Avoid showing FCC on empty text field in a different way
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-04 11:14 PST by Yongxin Dai
Modified: 2012-12-05 07:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.91 KB, patch)
2012-12-04 20:14 PST, Yongxin Dai 		no flags Details | Formatted Diff | Diff
Patch (4.91 KB, patch)
2012-12-05 07:26 PST, Yongxin Dai 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongxin Dai 2012-12-04 11:14:06 PST 
"Early return on empty text field"  causes problem (SHA 58b422c4). Now, we avoid showing FCC on empty text field in a different way. If the text field is empty, we always notify the client with non-touch triggered change. Thus, the FCC won’t show up.
Comment 1 Yongxin Dai 2012-12-04 20:14:18 PST 
Created attachment 177658 [details]
Patch
Comment 2 Rob Buis 2012-12-05 07:13:27 PST 
Comment on attachment 177658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177658&action=review

LGTM.

> Source/WebKit/blackberry/ChangeLog:11
> +        FineCursorContnrol is able to avoid showing FCC on empty text filed.

filed -> field
Comment 3 Yongxin Dai 2012-12-05 07:26:55 PST 
Created attachment 177744 [details]
Patch
Comment 4 Rob Buis 2012-12-05 07:30:41 PST 
Comment on attachment 177744 [details]
Patch

Ok.
Comment 5 WebKit Review Bot 2012-12-05 07:53:44 PST 
Comment on attachment 177744 [details]
Patch

Clearing flags on attachment: 177744

Committed r136689: <http://trac.webkit.org/changeset/136689>
Comment 6 WebKit Review Bot 2012-12-05 07:53:47 PST 
All reviewed patches have been landed.  Closing bug.