Bug 104010 - Remove empty directories
Summary: Remove empty directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2012-12-04 09:54 PST by Laszlo Gombos
Modified: 2013-10-09 03:43 PDT (History)
6 users (show)

See Also:


Attachments
list of empty directories (25.34 KB, text/plain)
2012-12-04 09:55 PST, Laszlo Gombos
no flags Details
script to find empty dirs in an svn repo (164 bytes, application/x-shellscript)
2012-12-04 09:56 PST, Laszlo Gombos
no flags Details
Patch (27.42 KB, text/plain)
2013-03-13 21:38 PDT, Jose Lejin PJ
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-12-04 09:54:40 PST
These are likely left behind from git. They do not cause any harm as far as I can tell, but we have quite a few of them (and I keep stumbling in them when just browsing/reading the code).

At r136399, we have about 500 directories, most of them under ./LayoutTests/platform but a fair size under Source.

Attached a list of empty directories and a small script to find them.
Comment 1 Laszlo Gombos 2012-12-04 09:55:10 PST
Created attachment 177502 [details]
list of empty directories
Comment 2 Laszlo Gombos 2012-12-04 09:56:23 PST
Created attachment 177503 [details]
script to find empty dirs in an svn repo
Comment 3 Csaba Osztrogonác 2012-12-04 14:39:31 PST
Yay, good proposal. ;) 

My dream is making "webkit-patch land" and CQ somehow remove empty directories
automatically when you removed the files in them. Unfortunately it isn't
trivial, because git can't handle empty directories at all. As far as I
know we can only remove orphaned empty directories manually (and regularly).
Comment 4 Jose Lejin PJ 2013-03-13 21:38:52 PDT
Created attachment 193061 [details]
Patch
Comment 5 Jose Lejin PJ 2013-03-13 21:46:45 PDT
I will resubmit the patch. Some error occurred while uploading patch with Tools/Scripts/webkit-patch upload. Remove empty directories details didn't come in patch.
Comment 6 Laszlo Gombos 2013-10-09 03:43:41 PDT
Most if this was taken care by http://trac.webkit.org/changeset/148159 . Also see http://trac.webkit.org/changeset/154749 and http://trac.webkit.org/changeset/156827. Closing.