Bug 10401 – REGRESSION: NUL characters rendered with non-zero width when font is Verdana

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Will Stoutin]

This is a regression from safari 2.0.3.

The title bar is pushed far to the right when it should be in the upper left corner, the page is twice as wide as it should be, a few of the objects are also pushed far right.

Page works fine in Camino, FF, Safari 2.0.3.

[Mark Rowe (bdash)]

Created attachment 10033 [details]
Reduced test case

It would seem as though Verdana has a non-zero-width glyph for NUL which is causing the width of a span within the source of the page to grow to contain the large run of them.  Mouse over to change the font between the default + Verdana to see the width of the span change.  Note that Firefox doesn't exhibit the same behaviour.

[Dave Hyatt]

We're not supposed to use non-zero widths for NUL.  The glyph width cache should have been hacked to account for this.

[Darin Adler]

(In reply to comment #2)
> We're not supposed to use non-zero widths for NUL.  The glyph width cache
> should have been hacked to account for this.

Here's the code that's supposed to do this, in GlyphMap:

            for (i = 0; i < 0x20; ++i)
                buffer[i] = ZERO_WIDTH_SPACE;

Thus we should be using a zero-width space for Unicode 0.

[Stephanie Lewis]

radar 4823085

*** Bug 11558 has been marked as a duplicate of this bug. ***

Testing in TextEdit on my system, I found out that Helvetica's zero-width space glyph has non-zero width. Verdana's zero-width space appeared to have zero width, but I think the problem in WebKit is only in particular sizes of Verdana, so it might be irrelevant to TextEdit if it uses a different renderingMode.

It looks like in addition to forcing nulls to be zero-width spaces, you need to force the width of the zero-width space glyph to 0.

[Dave Hyatt]

I think the code used to do that and I "simplified" (i.e., screwed it up) the code when I moved it to WebCore.

I think r18988 essentially fixed this bug by stripping null characters from text nodes.

[Dave Hyatt]

Is it possible to have NUL characters in generated content?  We should probably just put back the code that was in WebTextRenderer that I removed when doing the conversion.  I "simplified" the code. :)

[Mark Rowe (bdash)]

Radar shows this as fixed.