Bug 104000 - [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies.
Summary: [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 104101
  Show dependency tree / graph
 
Reported: 2012-12-04 07:27 PST by Krzysztof Czech
Modified: 2012-12-05 09:57 PST (History)
7 users (show)

See Also:

Attachments
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies (4.44 KB, patch)
2012-12-04 07:53 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies (1.40 KB, patch)
2012-12-05 01:41 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2012-12-04 07:27:50 PST 
Assistive Technologies should find a way to distinguish WebKit-EFL.
Comment 1 Krzysztof Czech 2012-12-04 07:53:50 PST 
Created attachment 177480 [details]
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies
Comment 2 Grzegorz Czajkowski 2012-12-04 08:03:14 PST 
LGTM.
Comment 3 Dominic Mazzoni 2012-12-04 08:27:59 PST 
Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.)
Comment 4 chris fleizach 2012-12-04 10:19:54 PST 
Comment on attachment 177480 [details]
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies

View in context: https://bugs.webkit.org/attachment.cgi?id=177480&action=review

> Source/WebCore/ChangeLog:8
> +        Introduce Webkit-EFL so that Assistive Technologies could distinguish it.

...so that Assistive Technologies "can" distinguish it.
Comment 5 chris fleizach 2012-12-04 10:20:25 PST 
(In reply to comment #3)
> Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.)

I agree with dominic here. Once that's done, it looks ready to go.
Comment 6 Krzysztof Czech 2012-12-05 01:41:07 PST 
Created attachment 177696 [details]
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies
Comment 7 Krzysztof Czech 2012-12-05 01:46:54 PST 
(In reply to comment #4)
> (From update of attachment 177480 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177480&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Introduce Webkit-EFL so that Assistive Technologies could distinguish it.
> 
> ...so that Assistive Technologies "can" distinguish it.
Thank you. Done.
Comment 8 Krzysztof Czech 2012-12-05 01:47:06 PST 
(In reply to comment #5)
> (In reply to comment #3)
> > Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.)
> 
> I agree with dominic here. Once that's done, it looks ready to go.
Done.
Comment 9 WebKit Review Bot 2012-12-05 09:57:07 PST 
Comment on attachment 177696 [details]
[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies

Clearing flags on attachment: 177696

Committed r136710: <http://trac.webkit.org/changeset/136710>
Comment 10 WebKit Review Bot 2012-12-05 09:57:10 PST 
All reviewed patches have been landed.  Closing bug.