WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
10399
RenderTextArea is unused
https://bugs.webkit.org/show_bug.cgi?id=10399
Summary
RenderTextArea is unused
Mark Rowe (bdash)
Reported
2006-08-14 19:54:45 PDT
While looking into the dead code elimination options of GCC (
bug 10394
) I noticed that it completely strips the implementation of RenderTextArea. Further investigation revealed that it is now unused.
Attachments
Patch
(17.50 KB, patch)
2006-08-14 19:57 PDT
,
Mark Rowe (bdash)
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2006-08-14 19:57:24 PDT
Created
attachment 10032
[details]
Patch
Dave Hyatt
Comment 2
2006-08-14 22:41:54 PDT
Comment on
attachment 10032
[details]
Patch r=me
Darin Adler
Comment 3
2006-08-15 08:04:54 PDT
Comment on
attachment 10032
[details]
Patch This patch doesn't go far enough! Four other source files that can be deleted entirely if you are deleting RenderTextArea: TextBox.h, TextBoxMac.mm, WebCoreTextArea.h, WebCoreTextArea.mm. It doesn't make sense to change the comment in WebCoreTextArea.mm -- that just makes it incorrect! What's actually going on is that's dead code too.
Darin Adler
Comment 4
2006-08-15 08:20:15 PDT
Committed revision 15879.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug