RESOLVED FIXED 103989
[V8] Replace String::New("symbol") with String::NewSymbol("symbol") 
https://bugs.webkit.org/show_bug.cgi?id=103989
Summary [V8] Replace String::New("symbol") with String::NewSymbol("symbol")
Kentaro Hara
Reported 2012-12-04 02:57:05 PST
In V8, a symbol lookup is faster than a string lookup. We should use String::NewSymbol("symbol") for symbols.
Attachments
Patch (14.89 KB, patch)
2012-12-04 02:58 PST, Kentaro Hara 		haraken: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-04 02:58:21 PST
Created attachment 177462 [details] Patch
Kentaro Hara
Comment 2 2012-12-04 02:59:03 PST
If this patch looks OK, I'll do the rest of the replacements.
Adam Barth
Comment 3 2012-12-04 08:39:38 PST
Comment on attachment 177462 [details] Patch Ok. The only downside might be that NewSymbol is slower to create.
Kentaro Hara
Comment 4 2012-12-04 16:28:46 PST
Committed r136589: <http://trac.webkit.org/changeset/136589>
Kentaro Hara
Comment 5 2012-12-04 16:29:34 PST
Comment on attachment 177462 [details] Patch Landed manually.
Note You need to log in before you can comment on or make changes to this bug.