Bug 103987 - [V8] Remove toV8Object()
Summary: [V8] Remove toV8Object()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-04 02:35 PST by Kentaro Hara
Modified: 2012-12-04 21:12 PST (History)
8 users (show)

See Also:

Attachments
Patch (21.98 KB, patch)
2012-12-04 02:37 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (22.10 KB, patch)
2012-12-04 03:21 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (22.12 KB, patch)
2012-12-04 03:46 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-12-04 02:35:17 PST 
toV8Object() is used only for MessagePort and ArrayBuffer only by SerializedScriptValue. It is wasteful to generate toV8Object() for all interfaces.
Comment 1 Kentaro Hara 2012-12-04 02:37:58 PST 
Created attachment 177457 [details]
Patch
Comment 2 Dan Carney 2012-12-04 03:18:52 PST 
You're changing the return value in WebArrayBuffer and WebBlob when m_private is 0. It may be correct to do so, but it was never like this before.
Comment 3 Kentaro Hara 2012-12-04 03:21:34 PST 
Created attachment 177463 [details]
Patch
Comment 4 Kentaro Hara 2012-12-04 03:22:29 PST 
(In reply to comment #2)
> You're changing the return value in WebArrayBuffer and WebBlob when m_private is 0. It may be correct to do so, but it was never like this before.

Good point! Fixed. (Though I guess returning v8::Null() would be a correct behavior. Either way let's fix it in a follow-up patch.)
Comment 5 WebKit Review Bot 2012-12-04 03:39:41 PST 
Comment on attachment 177463 [details]
Patch

Attachment 177463 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15126592
Comment 6 Peter Beverloo (cr-android ews) 2012-12-04 03:43:53 PST 
Comment on attachment 177463 [details]
Patch

Attachment 177463 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15117858
Comment 7 Kentaro Hara 2012-12-04 03:46:24 PST 
Created attachment 177466 [details]
Patch
Comment 8 WebKit Review Bot 2012-12-04 21:12:09 PST 
Comment on attachment 177466 [details]
Patch

Clearing flags on attachment: 177466

Committed r136634: <http://trac.webkit.org/changeset/136634>
Comment 9 WebKit Review Bot 2012-12-04 21:12:13 PST 
All reviewed patches have been landed.  Closing bug.