Bug 103981 - [V8] Remove v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString()
Summary: [V8] Remove v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWeb...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Reported: 2012-12-04 01:06 PST by Kentaro Hara
Modified: 2012-12-04 20:23 PST (History)
3 users (show)

See Also:

Patch (7.56 KB, patch)
2012-12-04 01:13 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-12-04 01:06:50 PST
v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString() are equivalent to what StringResource does.
Comment 1 Kentaro Hara 2012-12-04 01:13:37 PST
Created attachment 177442 [details]
Comment 2 WebKit Review Bot 2012-12-04 20:07:53 PST
Comment on attachment 177442 [details]

Rejecting attachment 177442 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
it line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
 + 7b079df...6502679 HEAD       -> origin/HEAD  (forced update)
error: Ref refs/remotes/origin/master is at 6502679cc4e791c06a9f646d2448d49b53086645 but expected 7b079dfc6ebf2ea19fa6c8a1fb960775578416e5
 ! 7b079df...6502679 master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15132724
Comment 3 WebKit Review Bot 2012-12-04 20:23:23 PST
Comment on attachment 177442 [details]

Clearing flags on attachment: 177442

Committed r136622: <http://trac.webkit.org/changeset/136622>
Comment 4 WebKit Review Bot 2012-12-04 20:23:26 PST
All reviewed patches have been landed.  Closing bug.