RESOLVED FIXED 103981
[V8] Remove v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString() 
https://bugs.webkit.org/show_bug.cgi?id=103981
Summary [V8] Remove v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWeb...
Kentaro Hara
Reported 2012-12-04 01:06:50 PST
v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString() are equivalent to what StringResource does.
Attachments
Patch (7.56 KB, patch)
2012-12-04 01:13 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-04 01:13:37 PST
Created attachment 177442 [details] Patch
WebKit Review Bot
Comment 2 2012-12-04 20:07:53 PST
Comment on attachment 177442 [details] Patch Rejecting attachment 177442 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: it line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit + 7b079df...6502679 HEAD -> origin/HEAD (forced update) error: Ref refs/remotes/origin/master is at 6502679cc4e791c06a9f646d2448d49b53086645 but expected 7b079dfc6ebf2ea19fa6c8a1fb960775578416e5 ! 7b079df...6502679 master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15132724
WebKit Review Bot
Comment 3 2012-12-04 20:23:23 PST
Comment on attachment 177442 [details] Patch Clearing flags on attachment: 177442 Committed r136622: <http://trac.webkit.org/changeset/136622>
WebKit Review Bot
Comment 4 2012-12-04 20:23:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.