Bug 103967 - [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
Summary: [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
: 103954 (view as bug list)
Depends on:
Blocks: 104046
  Show dependency tree / graph
 
Reported: 2012-12-03 20:49 PST by Dana Jansens
Modified: 2012-12-05 16:41 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2012-12-03 20:50 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (8.07 KB, patch)
2012-12-04 14:41 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (8.00 KB, patch)
2012-12-04 14:45 PST, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-12-03 20:49:41 PST 
[chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
Comment 1 Dana Jansens 2012-12-03 20:50:05 PST 
Created attachment 177404 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-03 20:53:13 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Dana Jansens 2012-12-03 21:08:20 PST 
*** Bug 103954 has been marked as a duplicate of this bug. ***
Comment 4 James Robinson 2012-12-03 23:12:34 PST 
Comment on attachment 177404 [details]
Patch

Look at Tools/DumpRenderTree/chromium/WebViewHost.cpp's implementation of createOutputSurface().  How will that work with this change?  We need some way to hook up the compositor's output surface to something we can use in a layout tests for DRT.

R- until we figure that out.
Comment 5 Dana Jansens 2012-12-04 10:22:22 PST 
Huh.. DRT works fine for me.. somehow.
Comment 6 Dana Jansens 2012-12-04 14:41:55 PST 
Created attachment 177568 [details]
Patch
Comment 7 Dana Jansens 2012-12-04 14:45:17 PST 
Created attachment 177572 [details]
Patch

Cleanup in WebViewHost
Comment 8 Dana Jansens 2012-12-04 14:59:50 PST 
The path to landing these things are:
1. This.
2. https://codereview.chromium.org/11348371/
3. https://bugs.webkit.org/show_bug.cgi?id=104046
4. Remove the #define USE_CC_OUTPUT_SURFACE from cc/
Comment 9 James Robinson 2012-12-05 16:32:11 PST 
Comment on attachment 177572 [details]
Patch

Looks good, although we'll still be passing a seemingly-empty interface around in WebViewHost.  We can fix that eventually...
Comment 10 WebKit Review Bot 2012-12-05 16:41:20 PST 
Comment on attachment 177572 [details]
Patch

Clearing flags on attachment: 177572

Committed r136779: <http://trac.webkit.org/changeset/136779>
Comment 11 WebKit Review Bot 2012-12-05 16:41:24 PST 
All reviewed patches have been landed.  Closing bug.