Bug 103941 – Build fix after r136444

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebCore Misc.

[KyungTae Kim]

r136444 blocks #include "JPEGImageDecoder.h" with #if USE(LIBJPEG),
but it should be #if !PLATFORM(QT) || (PLATFORM(QT) && USE(LIBJPEG)), same with the code using JPEGImageDecode (126 line).

[KyungTae Kim]

Created attachment 177355 [details]
Patch

[KyungTae Kim]

Source/WebCore/platform/image-decoders/ImageDecoder.cpp: In static member function ‘static WebCore::ImageDecoder* WebCore::ImageDecoder::create(const WebCore::SharedBuffer&, WebCore::ImageSource::AlphaOption, WebCore::ImageSource::GammaAndColorProfileOption)’:
Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:20: error: expected type-specifier before ‘JPEGImageDecoder’
Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:20: error: cannot convert ‘int*’ to ‘WebCore::ImageDecoder*’ in return
Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:20: error: expected ‘;’ before ‘JPEGImageDecoder’
Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:76: error: ‘JPEGImageDecoder’ was not declared in this scope

[Levi Weintraub]

Comment on attachment 177355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177355&action=review

> Source/WebCore/ChangeLog:9
> +        Unreviewd build fix
> +
> +        r136444 blocks #include "JPEGImageDecoder.h" with #if USE(LIBJPEG),
> +        but it should be #if !PLATFORM(QT) || (PLATFORM(QT) && USE(LIBJPEG)).

Typo: "Unreviewd". Qualify the revision with a link and don't worry about writing the entire patch in the description. Just say the platform that's broken.

[KyungTae Kim]

*** This bug has been marked as a duplicate of bug 103938 ***

[Laszlo Gombos]

Comment on attachment 177355 [details]
Patch

removing cq? as this is a dup of a fixed bug.