Bug 103933 - ShadowRoot should recalcStyle for itself
Summary: ShadowRoot should recalcStyle for itself
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-03 14:55 PST by Elliott Sprehn
Modified: 2012-12-05 05:12 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2012-12-03 15:01 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2012-12-03 15:18 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch (4.02 KB, patch)
2012-12-03 17:09 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch for landing (4.19 KB, patch)
2012-12-05 01:51 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2012-12-03 14:55:09 PST 
ShadowRoot should recalcStyle for itself
Comment 1 Elliott Sprehn 2012-12-03 15:01:23 PST 
Created attachment 177341 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-03 15:11:20 PST 
Comment on attachment 177341 [details]
Patch

Attachment 177341 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15119506
Comment 3 Elliott Sprehn 2012-12-03 15:18:25 PST 
Created attachment 177347 [details]
Patch
Comment 4 Elliott Sprehn 2012-12-03 15:18:58 PST 
(In reply to comment #3)
> Created an attachment (id=177347) [details]
> Patch

My bad, ElementShadow is not a Node so you need to qualify Node::StyleChange.
Comment 5 Early Warning System Bot 2012-12-03 15:51:18 PST 
Comment on attachment 177347 [details]
Patch

Attachment 177347 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15119529
Comment 6 Early Warning System Bot 2012-12-03 16:01:11 PST 
Comment on attachment 177347 [details]
Patch

Attachment 177347 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15098756
Comment 7 Peter Beverloo (cr-android ews) 2012-12-03 17:00:49 PST 
Comment on attachment 177347 [details]
Patch

Attachment 177347 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15120577
Comment 8 Elliott Sprehn 2012-12-03 17:09:33 PST 
Created attachment 177377 [details]
Patch

Fix the build
Comment 9 Dimitri Glazkov (Google) 2012-12-03 19:48:46 PST 
Comment on attachment 177377 [details]
Patch

Morrita-san, can you take a look?
Comment 10 Hajime Morrita 2012-12-04 17:40:03 PST 
Comment on attachment 177377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177377&action=review

Looks good.

> Source/WebCore/dom/ShadowRoot.cpp:47
> +#include "Text.h"

Then we might no longer need to include Text.h in ElementShadow.cpp
Comment 11 Elliott Sprehn 2012-12-05 01:51:52 PST 
Created attachment 177700 [details]
Patch for landing
Comment 12 Elliott Sprehn 2012-12-05 01:54:41 PST 
(In reply to comment #10)
> (From update of attachment 177377 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177377&action=review
> 
> ...
> > Source/WebCore/dom/ShadowRoot.cpp:47
> > +#include "Text.h"
> 
> Then we might no longer need to include Text.h in ElementShadow.cpp

Done. Just need a cq+ :)
Comment 13 WebKit Review Bot 2012-12-05 05:12:52 PST 
Comment on attachment 177700 [details]
Patch for landing

Clearing flags on attachment: 177700

Committed r136675: <http://trac.webkit.org/changeset/136675>
Comment 14 WebKit Review Bot 2012-12-05 05:12:57 PST 
All reviewed patches have been landed.  Closing bug.