Bug 103930 – [BlackBerry] Store rendered regions in pixel contents coordinates

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jakob Petsovits]

Currently, the rendered region of a tile is stored in coordinates relative to the tile origin. This brings no benefits whatsoever and causes a lot of unnecessary transformations, together with the potential of incorrectly transforming rendered regions.

By storing the rendered region as what it is (actual pixel coordinates relative to the page origin), everything is more compact, easier to understand and easier to use with other existing functionality.

[Jakob Petsovits]

Created attachment 177336 [details]
Patch

[Rob Buis]

Comment on attachment 177336 [details]
Patch

LGTM.

[WebKit Review Bot]

Attachment 177336 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BackingStore...." exit_code: 1
Source/WebKit/blackberry/Api/BackingStore.cpp:1456:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/Api/BackingStore.cpp:1602:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/Api/BackingStore.cpp:1634:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/Api/BackingStore.cpp:2221:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jakob Petsovits]

Created attachment 177365 [details]
Patch

With much love to the stylebot for punishing me for Adam's weird argument passing style.

[Jakob Petsovits]

Comment on attachment 177365 [details]
Patch

Wait, no, that didn't work. I thought I had Rob added to the ChangeLog for his previous review.

[Jakob Petsovits]

Created attachment 177366 [details]
Patch

There we go.

[Jakob Petsovits]

Comment on attachment 177366 [details]
Patch

Reviewed by Rob above, with only the style changes that the bot requested.

[WebKit Review Bot]

Comment on attachment 177366 [details]
Patch

Rejecting attachment 177366 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
it line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
 + 47362e2...11ff3a0 HEAD       -> origin/HEAD  (forced update)
error: Ref refs/remotes/origin/master is at 11ff3a04a1253c816672777de9904bb4958f6164 but expected 47362e29d772f5dceffea68840d001b228849649
 ! 47362e2...11ff3a0 master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15133278

[WebKit Review Bot]

Comment on attachment 177366 [details]
Patch

Clearing flags on attachment: 177366

Committed r136503: <http://trac.webkit.org/changeset/136503>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.