Bug 103929 - Disable WebKit2 api tests on Apple Windows port
Summary: Disable WebKit2 api tests on Apple Windows port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-03 14:33 PST by Roger Fong
Modified: 2013-01-04 00:53 PST (History)
5 users (show)

See Also:

Attachments
patch (1.59 KB, patch)
2012-12-03 14:48 PST, Roger Fong 		no flags Details | Formatted Diff | Diff
patch (1.20 KB, patch)
2012-12-03 15:49 PST, Roger Fong 		thorton: review+
Details | Formatted Diff | Diff
less whacky (1.18 KB, text/plain)
2012-12-03 16:09 PST, Roger Fong 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2012-12-03 14:33:01 PST 
We will be disabling WebKit2 API tests.
Disabling WebKit2 API tests for Windows port.
Comment 1 Roger Fong 2012-12-03 14:48:49 PST 
Created attachment 177338 [details]
patch
Comment 2 Tim Horton 2012-12-03 14:58:56 PST 
Comment on attachment 177338 [details]
patch

Can we early-"next" instead of nesting the meat of the function?
Comment 3 Roger Fong 2012-12-03 15:49:49 PST 
Created attachment 177358 [details]
patch
Comment 4 Tim Horton 2012-12-03 15:57:06 PST 
Comment on attachment 177358 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177358&action=review

> Tools/Scripts/run-api-tests:276
> +       } elsif (!isAppleWinWebKit() || $suite !~ m/WebKit2*/) {
> +          # Disabling WebKit2 API test on Windows since we will be disabling WebKit2 on Windows.

A little wacky but better, but maybe use next to make it less wacky.
Comment 5 Roger Fong 2012-12-03 16:09:17 PST 
Created attachment 177363 [details]
less whacky
Comment 6 Roger Fong 2012-12-03 16:53:13 PST 
http://trac.webkit.org/changeset/136456
Comment 7 Eric Seidel (no email) 2013-01-04 00:53:56 PST 
Comment on attachment 177363 [details]
less whacky

Cleared review? from attachment 177363 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).