Bug 103928 - Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
Summary: Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-03 14:27 PST by Elliott Sprehn
Modified: 2012-12-04 14:44 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2012-12-03 14:28 PST, Elliott Sprehn
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2012-12-03 14:35 PST, Elliott Sprehn
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2012-12-03 14:27:37 PST
Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
Comment 1 Elliott Sprehn 2012-12-03 14:28:52 PST
Created attachment 177331 [details]
Patch
Comment 2 Build Bot 2012-12-03 14:33:14 PST
Comment on attachment 177331 [details]
Patch

Attachment 177331 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15097717
Comment 3 Elliott Sprehn 2012-12-03 14:35:51 PST
Created attachment 177335 [details]
Patch
Comment 4 WebKit Review Bot 2012-12-03 18:11:03 PST
Comment on attachment 177335 [details]
Patch

Rejecting attachment 177335 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/15121508
Comment 5 Elliott Sprehn 2012-12-03 18:12:17 PST
(In reply to comment #4)
> (From update of attachment 177335 [details])
> Rejecting attachment 177335 [details] from commit-queue.
> 
> New failing tests:
> inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
> Full output: http://queues.webkit.org/results/15121508

Seems super unlikely I broke the debugger... :)
Comment 6 Dirk Pranke 2012-12-04 14:44:51 PST
Comment on attachment 177335 [details]
Patch

Clearing flags on attachment: 177335

Committed r136577: <http://trac.webkit.org/changeset/136577>
Comment 7 Dirk Pranke 2012-12-04 14:44:53 PST
All reviewed patches have been landed.  Closing bug.