Currently the front-end needs to query the back-end for metadata during these two handlers. In multi-process ports (like Chromium) that may be a synchronous IPC call. Since the data will be needed anyway, the back-end should just supply it along with the other data in the (async) callbacks.
Created attachment 184573 [details] Patch
jsbell@ - r?
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 184573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184573&action=review lgtm, knowing that there will be a cleanup pass that removes all the duplicate methods > Source/WebKit/chromium/src/IDBCallbacksProxy.cpp:185 > + m_callbacks->onUpgradeNeeded(oldVersion, 0, new WebIDBDatabaseImpl(database, m_databaseCallbacks)); Question for reviewers: 0 is still preferred over nullptr, correct? > Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp:82 > + m_callbacks->onSuccess(localDatabaseProxy, localDatabaseProxy->metadata()); Nit: can use localDatabaseProxy.release() to avoid refcount churn > Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp:92 > + m_callbacks->onSuccess(localDatabaseProxy, metadata); Nit: can use localDatabaseProxy.release() to avoid refcount churn
Created attachment 184587 [details] Patch
dglazkov - r? (mostly webkit API refactoring)
Comment on attachment 184587 [details] Patch optimistically landing now that the smoke has cleared from the earlier test failures.
Comment on attachment 184587 [details] Patch Clearing flags on attachment: 184587 Committed r141049: <http://trac.webkit.org/changeset/141049>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 108151
Link to failing tests?
Created attachment 185261 [details] Patch for landing
Comment on attachment 185261 [details] Patch for landing Rejecting attachment 185261 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 185261, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: patching file Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp Hunk #2 succeeded at 128 (offset -5 lines). patching file Source/WebKit/chromium/src/WebIDBCallbacksImpl.h Hunk #2 succeeded at 59 with fuzz 1 (offset -1 lines). patching file Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp patching file Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16022335
Created attachment 185274 [details] Patch for landing
Comment on attachment 185274 [details] Patch for landing Clearing flags on attachment: 185274 Committed r141142: <http://trac.webkit.org/changeset/141142>