setIsInTopLayer is not really a setter
Created attachment 177298 [details] Patch
Comment on attachment 177298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177298&action=review > Source/WebCore/html/HTMLDialogElement.cpp:56 > - setIsInTopLayer(false); > + document()->addToTopLayer(this); Isn't this reversed?
Comment on attachment 177298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177298&action=review >> Source/WebCore/html/HTMLDialogElement.cpp:56 >> + document()->addToTopLayer(this); > > Isn't this reversed? Err, yes it is.
Should I be concerned that tests didn't catch that? (Or is it just that they hadn't run yet.)
(In reply to comment #4) > Should I be concerned that tests didn't catch that? (Or is it just that they hadn't run yet.) There's definitely dialog tests for when they display, it seems the mac port doesn't enable the build flag for dialog and the chromium bot is busted and not applying patches :/
Created attachment 177307 [details] Patch
Comment on attachment 177307 [details] Patch OK.
Comment on attachment 177307 [details] Patch Attachment 177307 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15106603
Created attachment 177316 [details] Patch
(In reply to comment #9) > Created an attachment (id=177316) [details] > Patch Stupid typo, setInTopLayer => setIsInTopLayer.
Comment on attachment 177316 [details] Patch Rejecting attachment 177316 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ripts/update-webkit line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit f10c1a4..e507ad4 HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at e507ad4c79d65f31547bf48bfa32467849b3b8e5 but expected f10c1a4675c348ff6c5220ad7a631f0f400f381a ! f10c1a4..e507ad4 master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15120536
Either the cq-bot's checkout is hosed, or the git.webkit.org master is confused... or both.
Comment on attachment 177316 [details] Patch Clearing flags on attachment: 177316 Committed r136575: <http://trac.webkit.org/changeset/136575>
All reviewed patches have been landed. Closing bug.