WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103904
[EFL] Fix tools for WebKit2-only builds
https://bugs.webkit.org/show_bug.cgi?id=103904
Summary
[EFL] Fix tools for WebKit2-only builds
Laszlo Gombos
Reported
2012-12-03 09:10:29 PST
run-launcher --efl -2 fails in a WebKit2-only build (WebKit$ ./Tools/Scripts/build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF"). This is likely an issue with the scripts as running MiniBrowser from the bin directory runs just fine.
Attachments
Patch
(1.22 KB, patch)
2012-12-06 18:42 PST
,
KyungTae Kim
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
KyungTae Kim
Comment 1
2012-12-06 18:42:43 PST
Created
attachment 178132
[details]
Patch
KyungTae Kim
Comment 2
2012-12-06 18:48:17 PST
run-launcher --efl -2 checked library path as WebKitBuild/Release/lib/libwebkit.so, and died because it does not exist in ENABLE_WEBKIT=OFF case. In library path check routine (checkFrameworks -> builtDylibPathForName), there was no consider for WK2 case.
Laszlo Gombos
Comment 3
2012-12-07 08:38:22 PST
Comment on
attachment 178132
[details]
Patch r=me.
WebKit Review Bot
Comment 4
2012-12-07 08:55:28 PST
Comment on
attachment 178132
[details]
Patch Clearing flags on attachment: 178132 Committed
r136957
: <
http://trac.webkit.org/changeset/136957
>
WebKit Review Bot
Comment 5
2012-12-07 08:55:32 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug