Bug 103904 - [EFL] Fix tools for WebKit2-only builds
Summary: [EFL] Fix tools for WebKit2-only builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2012-12-03 09:10 PST by Laszlo Gombos
Modified: 2012-12-07 08:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2012-12-06 18:42 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-12-03 09:10:29 PST 
run-launcher --efl -2 fails in a WebKit2-only build (WebKit$ ./Tools/Scripts/build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF"). This is likely an issue with the scripts as running MiniBrowser from the  bin directory runs just fine.
Comment 1 KyungTae Kim 2012-12-06 18:42:43 PST 
Created attachment 178132 [details]
Patch
Comment 2 KyungTae Kim 2012-12-06 18:48:17 PST 
run-launcher --efl -2 checked library path as WebKitBuild/Release/lib/libwebkit.so, 
and died because it does not exist in ENABLE_WEBKIT=OFF case.

In library path check routine (checkFrameworks -> builtDylibPathForName),
there was no consider for WK2 case.
Comment 3 Laszlo Gombos 2012-12-07 08:38:22 PST 
Comment on attachment 178132 [details]
Patch

r=me.
Comment 4 WebKit Review Bot 2012-12-07 08:55:28 PST 
Comment on attachment 178132 [details]
Patch

Clearing flags on attachment: 178132

Committed r136957: <http://trac.webkit.org/changeset/136957>
Comment 5 WebKit Review Bot 2012-12-07 08:55:32 PST 
All reviewed patches have been landed.  Closing bug.