WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103888
Web Inspector: free Page resources on inspector disconnect
https://bugs.webkit.org/show_bug.cgi?id=103888
Summary
Web Inspector: free Page resources on inspector disconnect
Konrad Piascik
Reported
2012-12-03 06:38:08 PST
Web Inspector: free Page resources on inspector disconnect
Attachments
Patch
(2.73 KB, patch)
2012-12-03 06:41 PST
,
Konrad Piascik
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Konrad Piascik
Comment 1
2012-12-03 06:41:35 PST
Created
attachment 177245
[details]
Patch
WebKit Review Bot
Comment 2
2012-12-03 09:55:18 PST
Comment on
attachment 177245
[details]
Patch Clearing flags on attachment: 177245 Committed
r136408
: <
http://trac.webkit.org/changeset/136408
>
WebKit Review Bot
Comment 3
2012-12-03 09:55:21 PST
All reviewed patches have been landed. Closing bug.
Pavel Feldman
Comment 4
2012-12-03 10:28:22 PST
Comment on
attachment 177245
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=177245&action=review
> Source/WebCore/inspector/InspectorController.cpp:257 > + m_overlay->freePage();
nit: I'd call this reset.
Konrad Piascik
Comment 5
2012-12-03 10:42:28 PST
Comment on
attachment 177245
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=177245&action=review
>> Source/WebCore/inspector/InspectorController.cpp:257 >> + m_overlay->freePage(); > > nit: I'd call this reset.
the reset method already exists for InspectorOverlay class
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug