Bug 103887 - Add Opera-submitted W3C <track> tests to LayoutTests
Summary: Add Opera-submitted W3C <track> tests to LayoutTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://w3c-test.org/html/tests/submis...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-12-03 06:08 PST by Antoine Quint
Modified: 2012-12-03 17:08 PST (History)
7 users (show)

See Also:

Attachments
Patch (deleted)
2012-12-03 06:33 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (deleted)
2012-12-03 06:59 PST, Antoine Quint 		eric.carlson: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (deleted)
2012-12-03 14:17 PST, Antoine Quint 		eric.carlson: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2012-12-03 06:08:13 PST 
Opera has submitted a host of <track> tests to W3C, they're hosted at http://w3c-test.org/html/tests/submission/Opera/media/. We should have a copy as LayoutTests so that we may use those as regression tests. Initially we'd skip all failing tests and work on passing all tests as we go forward.
Comment 1 Radar WebKit Bug Importer 2012-12-03 06:08:57 PST 
<rdar://problem/12796134>
Comment 2 Antoine Quint 2012-12-03 06:33:17 PST 
Created attachment 177243 [details]
Patch
Comment 3 Antoine Quint 2012-12-03 06:59:14 PST 
Created attachment 177247 [details]
Patch
Comment 4 Eric Carlson 2012-12-03 07:36:00 PST 
Comment on attachment 177247 [details]
Patch

rs=me
Comment 5 WebKit Review Bot 2012-12-03 08:02:05 PST 
Attachment 177247 [details] did not pass style-queue:

ERROR: Unexpected diff format when parsing a chunk: ''
ERROR: Unexpected diff format when parsing a chunk: 'cr'
ERROR: Unexpected diff format when parsing a chunk: '00:00:00.000 --> 00:00:01.000'
ERROR: Unexpected diff format when parsing a chunk: '{"id":"cr"}'
ERROR: Unexpected diff format when parsing a chunk: 'lfcr'
ERROR: Unexpected diff format when parsing a chunk: '00:00:00.000 --> 00:00:01.000'
LayoutTests/platform/chromium/TestExpectations:3016:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3017:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3018:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3019:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3020:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3021:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3022:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3023:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3024:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3025:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3026:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3027:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3028:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3029:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3030:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3031:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3032:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3033:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3034:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3035:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3036:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3037:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3038:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3039:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3040:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3041:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3042:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3043:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3044:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3045:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3046:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3047:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3048:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3049:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3050:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3051Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1
:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3052:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3053:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:540:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:541:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:542:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:543:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:544:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:545:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:546:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:547:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:548:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:549:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:550:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:551:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:552:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:553:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:554:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:555:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:556:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:557:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:558:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:559:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:560:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:561:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:562:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:563:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:564:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:565:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:566:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:567:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:568:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:569:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:570:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:571:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:572:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:573:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:574:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:575:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:576:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:577:  Test lacks BUG modifier.  [test/expectations] [5]
Total errors found: 76 in 642 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Review Bot 2012-12-03 08:48:31 PST 
Comment on attachment 177247 [details]
Patch

Rejecting attachment 177247 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/TestExpectations:573:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:574:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:575:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:576:  Test lacks BUG modifier.  [test/expectations] [5]
LayoutTests/platform/gtk/TestExpectations:577:  Test lacks BUG modifier.  [test/expectations] [5]
Total errors found: 76 in 6 files

Full output: http://queues.webkit.org/results/15086964
Comment 7 Antoine Quint 2012-12-03 14:17:33 PST 
Created attachment 177326 [details]
Patch

Patch now references https://bugs.webkit.org/show_bug.cgi?id=103926 to unskip all <track> tests on all platforms.
Comment 8 Eric Carlson 2012-12-03 14:28:46 PST 
Comment on attachment 177326 [details]
Patch

rs=me
Comment 9 WebKit Review Bot 2012-12-03 15:07:42 PST 
Comment on attachment 177326 [details]
Patch

Rejecting attachment 177326 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
tTests/platform/gtk/TestExpectations
Hunk #1 succeeded at 532 (offset -3 lines).
patching file LayoutTests/platform/mac/TestExpectations
patching file LayoutTests/platform/qt/TestExpectations
Hunk #1 succeeded at 895 (offset -3 lines).
patching file LayoutTests/platform/win/TestExpectations
Hunk #1 succeeded at 1553 (offset 1 line).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Carls..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15120512
Comment 10 Dean Jackson 2012-12-03 17:08:12 PST 
Landed manually and painfully in http://trac.webkit.org/changeset/136459
I hope I didn't screw anything up.