Bug 103885 – WebGL: use pointer to the source data for Image directly in texImage2D and texSubImage2D to avoid memory copy if no conversion is needed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Jun Jiang]

In current implementation of texImage2D() and texSubImage2D() in WebGL, there is a redundant memory copy from Image data to the intermediate vector when no conversion is needed. If the Image resource can be locked properly, it is better to use the pointer to the image source directly and hence avoid the memory copy to the intermediate vector.

[Jun Jiang]

Created attachment 177248 [details]
Patch

[Kenneth Russell]

Comment on attachment 177248 [details]
Patch

Looks good. r=me

[WebKit Review Bot]

Comment on attachment 177248 [details]
Patch

Rejecting attachment 177248 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   cf46854..c0a4c3a  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at c0a4c3a40ce96884ae4c1472ef9d4edf6af9b111 but expected cf468540ddb668d426e32e33bac10f014c7390a6
 ! cf46854..c0a4c3a  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15133667

[Jun Jiang]

Created attachment 177691 [details]
Patch

[Jun Jiang]

Hi, Kenneth. The patch fail to land into the code base from commit queue and I can't find any clue about its failure. 
I just re-based the patch, test it and upload it again. Please help to review and land it.

[Kenneth Russell]

Comment on attachment 177691 [details]
Patch

Let's try again. There were issues with the commit queue yesterday.

[WebKit Review Bot]

Comment on attachment 177691 [details]
Patch

Clearing flags on attachment: 177691

Committed r136745: <http://trac.webkit.org/changeset/136745>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.