Bug 103864 – Coordinated Graphics: Move AreaAllocator and UpdateAtlas to CoordinatedGraphics

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Jae Hyun Park]

AreaAllocator and UpdateAtlas is only used for Coordinated Graphics. So, these must be moved to CoordinatedGraphics to clarify the code.

[Jae Hyun Park]

Created attachment 177201 [details]
Patch

[Dongseong Hwang]

Comment on attachment 177201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177201&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp:21
> +

We need "#if USE(COORDINATED_GRAPHICS)" like UpdateAtlas.
Do we need to add Coordinated prefix?

[Jae Hyun Park]

Created attachment 177420 [details]
Patch

[Jae Hyun Park]

(In reply to comment #2)
> (From update of attachment 177201 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177201&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp:21
> > +
> 
> We need "#if USE(COORDINATED_GRAPHICS)" like UpdateAtlas.

Fixed.

> Do we need to add Coordinated prefix?

I'm not sure about this. Any comments?

[Kenneth Rohde Christiansen]

Comment on attachment 177420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177420&action=review

> Source/WebKit2/ChangeLog:8
> +        AreaAllocator and UpdateAtlas is only used for Coordinated Graphics.

are*

> Source/WebKit2/ChangeLog:9
> +        So, these must be moved to CoordinatedGraphics to clarify the code.

s/much/should

> Source/WebKit2/ChangeLog:12
> +

So why isn't something like the UpdateAtlas useful for something not using coordinated graphics? Is there a chance it will be moved back again?

[Jae Hyun Park]

Created attachment 177440 [details]
Patch

[Jae Hyun Park]

(In reply to comment #5)
> (From update of attachment 177420 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177420&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        AreaAllocator and UpdateAtlas is only used for Coordinated Graphics.
> 
> are*
Fixed.

> 
> > Source/WebKit2/ChangeLog:9
> > +        So, these must be moved to CoordinatedGraphics to clarify the code.
> 
> s/much/should
Fixed.

> 
> > Source/WebKit2/ChangeLog:12
> > +
> 
> So why isn't something like the UpdateAtlas useful for something not using coordinated graphics? Is there a chance it will be moved back again?

Thanks for the review!

First of all, UpdateAtlas is not used in any other codes other than Coordinated Graphics. So, it belongs to Coordinated Graphics.

Also, as far as I know, there aren't any plans on using UpdateAtlas other than Coordinated Graphics.

[WebKit Review Bot]

Comment on attachment 177440 [details]
Patch

Clearing flags on attachment: 177440

Committed r136760: <http://trac.webkit.org/changeset/136760>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.