Bug 103864 - Coordinated Graphics: Move AreaAllocator and UpdateAtlas to CoordinatedGraphics
Summary: Coordinated Graphics: Move AreaAllocator and UpdateAtlas to CoordinatedGraphics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 102994
  Show dependency tree / graph
 
Reported: 2012-12-03 00:35 PST by Jae Hyun Park
Modified: 2012-12-05 13:58 PST (History)
8 users (show)

See Also:

Attachments
Patch (49.94 KB, patch)
2012-12-03 00:51 PST, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Patch (50.12 KB, patch)
2012-12-03 22:55 PST, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Patch (50.12 KB, patch)
2012-12-04 01:10 PST, Jae Hyun Park 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Hyun Park 2012-12-03 00:35:32 PST 
AreaAllocator and UpdateAtlas is only used for Coordinated Graphics. So, these must be moved to CoordinatedGraphics to clarify the code.
Comment 1 Jae Hyun Park 2012-12-03 00:51:58 PST 
Created attachment 177201 [details]
Patch
Comment 2 Dongseong Hwang 2012-12-03 17:37:57 PST 
Comment on attachment 177201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177201&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp:21
> +

We need "#if USE(COORDINATED_GRAPHICS)" like UpdateAtlas.
Do we need to add Coordinated prefix?
Comment 3 Jae Hyun Park 2012-12-03 22:55:01 PST 
Created attachment 177420 [details]
Patch
Comment 4 Jae Hyun Park 2012-12-03 22:57:15 PST 
(In reply to comment #2)
> (From update of attachment 177201 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177201&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp:21
> > +
> 
> We need "#if USE(COORDINATED_GRAPHICS)" like UpdateAtlas.

Fixed.

> Do we need to add Coordinated prefix?

I'm not sure about this. Any comments?
Comment 5 Kenneth Rohde Christiansen 2012-12-04 00:43:02 PST 
Comment on attachment 177420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177420&action=review

> Source/WebKit2/ChangeLog:8
> +        AreaAllocator and UpdateAtlas is only used for Coordinated Graphics.

are*

> Source/WebKit2/ChangeLog:9
> +        So, these must be moved to CoordinatedGraphics to clarify the code.

s/much/should

> Source/WebKit2/ChangeLog:12
> +

So why isn't something like the UpdateAtlas useful for something not using coordinated graphics? Is there a chance it will be moved back again?
Comment 6 Jae Hyun Park 2012-12-04 01:10:15 PST 
Created attachment 177440 [details]
Patch
Comment 7 Jae Hyun Park 2012-12-04 01:22:12 PST 
(In reply to comment #5)
> (From update of attachment 177420 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177420&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        AreaAllocator and UpdateAtlas is only used for Coordinated Graphics.
> 
> are*
Fixed.

> 
> > Source/WebKit2/ChangeLog:9
> > +        So, these must be moved to CoordinatedGraphics to clarify the code.
> 
> s/much/should
Fixed.

> 
> > Source/WebKit2/ChangeLog:12
> > +
> 
> So why isn't something like the UpdateAtlas useful for something not using coordinated graphics? Is there a chance it will be moved back again?

Thanks for the review!

First of all, UpdateAtlas is not used in any other codes other than Coordinated Graphics. So, it belongs to Coordinated Graphics.

Also, as far as I know, there aren't any plans on using UpdateAtlas other than Coordinated Graphics.
Comment 8 WebKit Review Bot 2012-12-05 13:58:18 PST 
Comment on attachment 177440 [details]
Patch

Clearing flags on attachment: 177440

Committed r136760: <http://trac.webkit.org/changeset/136760>
Comment 9 WebKit Review Bot 2012-12-05 13:58:23 PST 
All reviewed patches have been landed.  Closing bug.