RESOLVED FIXED 103858
DFG should trigger rage conversion from double to contiguous if it sees a GetByVal on Double being used in an integer context 
https://bugs.webkit.org/show_bug.cgi?id=103858
Summary DFG should trigger rage conversion from double to contiguous if it sees a Get...
Filip Pizlo
Reported Monday, December 3, 2012 6:58:19 AM UTC
Patch forthcoming. This should undo some of the regressions from typed double arrays.
Attachments
the patch (22.51 KB, patch)
2012-12-02 23:03 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (25.77 KB, patch)
2012-12-02 23:52 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (25.76 KB, patch)
2012-12-02 23:57 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 Monday, December 3, 2012 7:03:16 AM UTC
Created attachment 177188 [details] the patch Not marking r? yet because I think I have some more tricks up my sleeve.
Filip Pizlo
Comment 2 Monday, December 3, 2012 7:52:05 AM UTC
Created attachment 177194 [details] the patch Made it even better.
WebKit Review Bot
Comment 3 Monday, December 3, 2012 7:54:35 AM UTC
Attachment 177194 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGArrayMode.h:198: The parameter name "flags" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4 Monday, December 3, 2012 7:57:54 AM UTC
Created attachment 177195 [details] the patch Fix style
Filip Pizlo
Comment 5 Monday, December 3, 2012 9:22:57 AM UTC
Landed in http://trac.webkit.org/changeset/136372
Note You need to log in before you can comment on or make changes to this bug.