Bug 103844 – [Qt] Use a separate QWEBKITWIDGETS_EXPORT macro for WebKitWidgets

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Pierre Rossi]

[Qt] Use a separate QWEBKITWIDGETS_EXPORT macro for WebKitWidgets

[Pierre Rossi]

Created attachment 177161 [details]
Patch

[Thiago Macieira]

Looks good to me.

Won't this break Qt 4 builds? Also, please note that InitWebKitQt.h will need some more work (see the bug I filed)

[Andras Becsi]

(In reply to comment #2)
> Looks good to me.
> 
> Won't this break Qt 4 builds? Also, please note that InitWebKitQt.h will need some more work (see the bug I filed)

We do not support Qt4 on trunk any more, so this should not be a problem, and as far as I can tell InitWebKitQt.h is only included in widget specific code (qtwebkitwidgets library), so it shouldn't be an issue either.

[Pierre Rossi]

Created attachment 177241 [details]
Patch

[Simon Hausmann]

Comment on attachment 177241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177241&action=review

Excellent solution. Fully agreed that this is much cleaner. Hadn't realized that qt_module.prf sets the QT_BUILDING_*_LIB macros automatically. Lovely.

Carefuly when landing wrt MSVC

> Source/WebKit/qt/WidgetSupport/InitWebKitQt.cpp:33
> -Q_DECL_EXPORT void initializeWebKitWidgets()
> +void initializeWebKitWidgets()

I think that this is likely to cause compilation errors on Windows. I've seen MSVC at least complain that the declaration had to match the definition. I suggest to land carefully in trunk first to see of the MSVC bot complains or not.

[Pierre Rossi]

(In reply to comment #5)
> (From update of attachment 177241 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177241&action=review
> 
> Excellent solution. Fully agreed that this is much cleaner. Hadn't realized that qt_module.prf sets the QT_BUILDING_*_LIB macros automatically. Lovely.
> 
> Carefuly when landing wrt MSVC
> 
> > Source/WebKit/qt/WidgetSupport/InitWebKitQt.cpp:33
> > -Q_DECL_EXPORT void initializeWebKitWidgets()
> > +void initializeWebKitWidgets()
> 
> I think that this is likely to cause compilation errors on Windows. I've seen MSVC at least complain that the declaration had to match the definition. I suggest to land carefully in trunk first to see of the MSVC bot complains or not.

Alright, I'll put it back for landing then, just to be on the safe side.

[Pierre Rossi]

Committed r136394: <http://trac.webkit.org/changeset/136394>