Bug 103837 – [Blackberry] Static code analysis warning fixes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[sfa]

Klocwork issues: 172, 174, 504, 505, 1488, 1489, 1490, 1491, 514, 516, 1363

[sfa]

add me to cc

[Alexey Proskuryakov]

In the past, we sometimes refused to address address static code analysis issues if that degraded code quality. Unless the tool has an unusually high success rate at finding real bugs, we may be better off not subscribing to maintaining it.

[sfa]

Created attachment 177289 [details]
static analysis patch

Patch only applies to BlackBerry port of webkit.

[sfa]

(In reply to comment #2)
> In the past, we sometimes refused to address address static code analysis issues if that degraded code quality. Unless the tool has an unusually high success rate at finding real bugs, we may be better off not subscribing to maintaining it.

Point taken, this patch is specific to the BB port of webkit and as such, it is desired by us to reduce potential future errors by addressing these items (disable op=/copy ctor, etc) over time. The general webkit project needs to decide on source code analysis independently and how the issues should be considered; that is out of scope for this item, sorry for the misunderstanding.

[Alexey Proskuryakov]

Thank you for the clarification.

One way to reduce confusion is to mark bugs that don't affect other platforms at all is a [Blackberry] prefix - that way, others will know that they don't need to look at the patch. But please use it carefully - even adding a platform specific ifdef to a cross platform file may make it important for core contributors to have a look.

[WebKit Review Bot]

Attachment 177289 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/blackberry/rss/RSSParserBase.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[sfa]

Created attachment 177308 [details]
style issue fixed in previous patch

[Rob Buis]

Comment on attachment 177308 [details]
style issue fixed in previous patch

LGTM.

[WebKit Review Bot]

Comment on attachment 177308 [details]
style issue fixed in previous patch

Rejecting attachment 177308 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   8dba0844..9cffc45 HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at 9cffc451c10239895188285fa8cdb2dbd36f385d but expected 8dba08445f9c28cad718f832239cd411fb8a245f
 ! 8dba0844..9cffc45 master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15120950

[sfa]

Created attachment 177528 [details]
Changelog patch failed to apply

[Rob Buis]

Comment on attachment 177528 [details]
Changelog patch failed to apply

Retrying.

[WebKit Review Bot]

Comment on attachment 177528 [details]
Changelog patch failed to apply

Clearing flags on attachment: 177528

Committed r136626: <http://trac.webkit.org/changeset/136626>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.