Bug 103820 - [CMake] Enable building WebKit2-only build for the EFL port
Summary: [CMake] Enable building WebKit2-only build for the EFL port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-01 14:41 PST by Laszlo Gombos
Modified: 2012-12-03 07:21 PST (History)
7 users (show)

See Also:

Attachments
proposed patch (3.54 KB, patch)
2012-12-01 16:02 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-12-01 14:41:38 PST 
build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF" should - in theory - disable WebKit1 for the EFL port but it does not. 

Patch is coming.
Comment 1 Laszlo Gombos 2012-12-01 16:02:18 PST 
Created attachment 177116 [details]
proposed patch

As a nice side benefit you can just build the EFL port with "cmake -DPORT=Efl $WEBKITSOURCEROOT". Previously you would have to issue "cmake -DPORT=Efl -DENABLE_WEBKIT=ON -DENABLE_WEBKIT2=ON $WEBKITSOURCEROOT" to get the same (default) configuration.
Comment 2 Ryuan Choi 2012-12-02 19:37:26 PST 
LGTM.

BTW, It makes webkit2 build as a default when we use 'cmake -DPORT=Efl'
Comment 3 Gyuyoung Kim 2012-12-02 22:56:05 PST 
Comment on attachment 177116 [details]
proposed patch

Looks fine. It would be good to add this option to EFL wiki page as well.
Comment 4 WebKit Review Bot 2012-12-03 07:21:45 PST 
Comment on attachment 177116 [details]
proposed patch

Clearing flags on attachment: 177116

Committed r136398: <http://trac.webkit.org/changeset/136398>
Comment 5 WebKit Review Bot 2012-12-03 07:21:49 PST 
All reviewed patches have been landed.  Closing bug.