RESOLVED FIXED103815
[CoordinatedGraphics] LayerTreeRenderer::removeImageBacking() calls HashMap::find() twice 
https://bugs.webkit.org/show_bug.cgi?id=103815
Summary [CoordinatedGraphics] LayerTreeRenderer::removeImageBacking() calls HashMap::...
Chris Dumez
Reported 2012-12-01 08:42:33 PST
LayerTreeRenderer::removeImageBacking() currently calls HashMap::find() twice for the same imageID: - Once explicitly to get an iterator - A second time implicitly by calling HashMap::remove(key) Since we already, have an iterator to the element, we should call HashMap::remove(iterator) to avoid calling HashMap::find() again.
Attachments
Patch (1.89 KB, patch)
2012-12-01 08:52 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-12-01 08:44:51 PST
Or we could just call HashMap::take() and make the code a bit simpler even.
Chris Dumez
Comment 2 2012-12-01 08:52:59 PST
Created attachment 177108 [details] Patch
WebKit Review Bot
Comment 3 2012-12-02 05:01:15 PST
Comment on attachment 177108 [details] Patch Clearing flags on attachment: 177108 Committed r136342: <http://trac.webkit.org/changeset/136342>
WebKit Review Bot
Comment 4 2012-12-02 05:01:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.