Bug 103794 – AX: the text of render counters are not exposed to Accessibility

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Use something like this and the text of "1, 2, 3" won't be exposed to accessibility

<style>
ol li::before { content: counter(l1) ":"; counter-increment: l1;}
ol li { list-style-type: decimial; display: block; }
</style>
<div style="counter-reset:l1;">
<ol style="list-style-type:decimal"><li>asdf<li>qwerwqer<li>yasdsf</ol>
</div>

[chris fleizach]

Created attachment 177070 [details]
patch

[WebKit Review Bot]

Comment on attachment 177070 [details]
patch

Attachment 177070 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15105131

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Ryosuke Niwa]

Comment on attachment 177070 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177070&action=review

> LayoutTests/accessibility/render-counter-text-expected.txt:3
> +line1
> +line2
> +line3

Could you hide this before the test finishes?

[chris fleizach]

rdar://10733019

[chris fleizach]

http://trac.webkit.org/changeset/139002

[Ryosuke Niwa]

accessibility/canvas-fallback-content-2.html started failing after this patch:

http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r139007%20(4529)/results.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=accessibility%2Fcanvas-fallback-content-2.html

[chris fleizach]

Weird. I'll look into it tonight.

[chris fleizach]

It looks like the <select> element are calculating textUnderElement() and the <option> elements are RenderText things. Looking how AX is done for popup buttons, it seems we are doing things incorrectly at least on the Mac.

The Mac should return the the selected <option> as the AXValue and not use the textUnderElement() as its title. There are a few tests that rely on pop up buttons having an AXTitle.

[Ryosuke Niwa]

Presumably http://trac.webkit.org/changeset/139077 fixes the test failure?

[chris fleizach]

(In reply to comment #9)
> Presumably http://trac.webkit.org/changeset/139077 fixes the test failure?

No, that was another bug semi-independent. I nearly have a fix ready for this one

[Ryosuke Niwa]

(In reply to comment #10)
> (In reply to comment #9)
> > Presumably http://trac.webkit.org/changeset/139077 fixes the test failure?
> 
> No, that was another bug semi-independent. I nearly have a fix ready for this one

Okay. It'll be great if you could upload & land that ASAP. Currently, it's only test failing on build.webkit.org ML/Lion release bots.

[chris fleizach]

here's the new bug
https://bugs.webkit.org/show_bug.cgi?id=106349A