Bug 103782 – IndexedDB: Propagate more leveldb errors to IDBIndex and IDBObjectStore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[David Grogan]

IndexedDB: Propagate more leveldb errors to IDBIndex and IDBObjectStore

[David Grogan]

Created attachment 177037 [details]
Patch

[David Grogan]

Josh and Alec, could one of you take a look?

[David Grogan]

Comment on attachment 177037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177037&action=review

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:670
> +        InternalError(IDBLevelDBBackingStoreReadError0);

With the every-callsite patch in limbo I used 0, but if that patch lands I will add more entries to the InternalError enum.

[David Grogan]

Created attachment 177559 [details]
Patch

[David Grogan]

Josh or Alec, could one of you take a look?

[Alec Flett]

Comment on attachment 177559 [details]
Patch

One nit, otherwise LGTM

View in context: https://bugs.webkit.org/attachment.cgi?id=177559&action=review

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:999
> +    exists = decodeInt(data.begin(), data.end()) == version;

Add parentheses for readability

[David Grogan]

Created attachment 177594 [details]
Patch

[David Grogan]

Tony, could you review this?

[David Grogan]

Comment on attachment 177559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177559&action=review

>> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:999
>> +    exists = decodeInt(data.begin(), data.end()) == version;
> 
> Add parentheses for readability

Done.

[Tony Chang]

Comment on attachment 177594 [details]
Patch

You may want to start adding WARN_UNUSED_RETURN to your functions to make sure people check the return value.

[David Grogan]

Created attachment 177601 [details]
Patch for landing

[David Grogan]

(In reply to comment #10)
> (From update of attachment 177594 [details])
> You may want to start adding WARN_UNUSED_RETURN to your functions to make sure people check the return value.

Thanks, done.

[David Grogan]

Committed r136592: <http://trac.webkit.org/changeset/136592>