Bug 103775 - Remove stale check in check-for-webkit-framework-include-consistency
Summary: Remove stale check in check-for-webkit-framework-include-consistency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 14:17 PST by Joseph Pecoraro
Modified: 2012-12-05 12:56 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.33 KB, patch)
2012-11-30 14:19 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix - Remove some more stale code (1.72 KB, patch)
2012-11-30 14:32 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-11-30 14:17:14 PST 
The radar claims this was fixed a long time ago with:
<http://webkit.org/b/56402> REGRESSION (WebKit2): keygen element doesn't work
r81173 - <http://trac.webkit.org/changeset/81173>

So we can remove the check in the build phase script.
Comment 1 Joseph Pecoraro 2012-11-30 14:19:39 PST 
Created attachment 177025 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2012-11-30 14:32:39 PST 
Created attachment 177026 [details]
[PATCH] Proposed Fix - Remove some more stale code

The "throw" in the unless block is already handled up above via "or throw". So drive-by remove the dead code.
Comment 3 David Kilzer (:ddkilzer) 2012-12-05 12:43:39 PST 
Comment on attachment 177026 [details]
[PATCH] Proposed Fix - Remove some more stale code

r=me
Comment 4 WebKit Review Bot 2012-12-05 12:56:48 PST 
Comment on attachment 177026 [details]
[PATCH] Proposed Fix - Remove some more stale code

Clearing flags on attachment: 177026

Committed r136743: <http://trac.webkit.org/changeset/136743>
Comment 5 WebKit Review Bot 2012-12-05 12:56:51 PST 
All reviewed patches have been landed.  Closing bug.