Bug 103761 - [CSS Grid Layout] Support calc() breadth size type
Summary: [CSS Grid Layout] Support calc() breadth size type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
: 126194 (view as bug list)
Depends on: 127033
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2012-11-30 12:24 PST by Xan Lopez
Modified: 2014-05-07 08:46 PDT (History)
23 users (show)

See Also:

Attachments
Patch (39.77 KB, patch)
2014-02-06 11:00 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (39.33 KB, patch)
2014-02-10 03:43 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2012-11-30 12:24:30 PST 
As discussed in bug #103335, it is not entirely clear yet how to support some aspects of breadth lengths defined with calc(), so opening a new bug to track just that. All the other types should have been handled in #103335.
Comment 1 Julien Chaffraix 2012-12-05 07:56:05 PST 
To whoever fix this bug, we should ensure that we have coverage for calc() inside minmax as bug 103799 didn't land any coverage for that.
Comment 2 Sergio Villar Senin 2013-09-19 01:04:19 PDT 
Taking a look...
Comment 3 Sergio Villar Senin 2014-02-04 08:05:36 PST 
This basically involves merging the same fix I did for blink:

    [CSS Grid Layout] Support calc() breadth track size
    
    The RenderGrid support for calc() was already there but we had to add also the CSSComputedStyle support. According to the specs
    
    BUG=297689
    
    Review URL: https://codereview.chromium.org/23472008
Comment 4 Sergio Villar Senin 2014-02-06 11:00:47 PST 
Created attachment 223348 [details]
Patch
Comment 5 Sergio Villar Senin 2014-02-10 03:43:01 PST 
Created attachment 223691 [details]
Patch
Comment 6 Sergio Villar Senin 2014-02-11 10:20:11 PST 
Comment on attachment 223691 [details]
Patch

Clearing flags on attachment: 223691

Committed r163888: <http://trac.webkit.org/changeset/163888>
Comment 7 Sergio Villar Senin 2014-02-11 10:20:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Sergio Villar Senin 2014-05-07 08:46:54 PDT 
*** Bug 126194 has been marked as a duplicate of this bug. ***