Bug 103759 - IndexedDB: Rename exception enum members from UGLY_ERR to PrettyError
Summary: IndexedDB: Rename exception enum members from UGLY_ERR to PrettyError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 11:30 PST by Joshua Bell
Modified: 2012-12-03 10:55 PST (History)
10 users (show)

See Also:

Attachments
Patch (66.96 KB, patch)
2012-11-30 11:37 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (68.82 KB, patch)
2012-12-03 09:44 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (70.21 KB, patch)
2012-12-03 10:07 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-11-30 11:30:20 PST 
IndexedDB: Rename exception enum members from UGLY_ERR to PrettyError
Comment 1 Joshua Bell 2012-11-30 11:37:37 PST 
Created attachment 176999 [details]
Patch
Comment 2 Joshua Bell 2012-11-30 11:38:36 PST 
dglazkov@ - r?
Comment 3 Joshua Bell 2012-12-03 09:44:44 PST 
Created attachment 177276 [details]
Patch
Comment 4 Joshua Bell 2012-12-03 09:44:55 PST 
Rebased. r? anyone?
Comment 5 WebKit Review Bot 2012-12-03 09:47:00 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 6 Erik Arvidsson 2012-12-03 09:48:52 PST 
Comment on attachment 177276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177276&action=review

> Source/WebKit/chromium/public/WebIDBDatabaseException.h:38
> +    WebIDBDatabaseExceptionDataError = 1203,
> +    WebIDBDatabaseExceptionQuotaError = 1212,

Can these just refer to the enum value instead of hard coding the value?
Comment 7 Joshua Bell 2012-12-03 09:52:34 PST 
(In reply to comment #6)
> (From update of attachment 177276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177276&action=review
> 
> > Source/WebKit/chromium/public/WebIDBDatabaseException.h:38
> > +    WebIDBDatabaseExceptionDataError = 1203,
> > +    WebIDBDatabaseExceptionQuotaError = 1212,
> 
> Can these just refer to the enum value instead of hard coding the value?

I don't believe includes from WebKit/chromium/public to WebCore are permitted.
Comment 8 Joshua Bell 2012-12-03 09:53:42 PST 
> I don't believe includes from WebKit/chromium/public to WebCore are permitted.

"Wait; strike that, reverse it."

...includes from WebCore by headers in WebKit/chromium/public...
Comment 9 WebKit Review Bot 2012-12-03 09:57:14 PST 
Comment on attachment 177276 [details]
Patch

Attachment 177276 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15098613
Comment 10 Joshua Bell 2012-12-03 10:07:29 PST 
Created attachment 177280 [details]
Patch
Comment 11 Joshua Bell 2012-12-03 10:07:45 PST 
... and webkit_unit_tests updated, derp.
Comment 12 WebKit Review Bot 2012-12-03 10:54:57 PST 
Comment on attachment 177280 [details]
Patch

Clearing flags on attachment: 177280

Committed r136417: <http://trac.webkit.org/changeset/136417>
Comment 13 WebKit Review Bot 2012-12-03 10:55:01 PST 
All reviewed patches have been landed.  Closing bug.