Bug 103758 - [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
Summary: [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 10:49 PST by Peter Beverloo
Modified: 2012-12-04 08:26 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.80 KB, patch)
2012-11-30 10:50 PST, Peter Beverloo 		no flags Details | Formatted Diff | Diff
Patch (5.80 KB, patch)
2012-11-30 11:03 PST, Peter Beverloo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-11-30 10:49:44 PST 
[Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
Comment 1 Peter Beverloo 2012-11-30 10:50:56 PST 
Created attachment 176996 [details]
Patch
Comment 2 Peter Beverloo 2012-11-30 10:56:05 PST 
A subsequent cleanup would be to actually order methods on ChromiumAndroidDriver by visibility, similar to the public/private groups ChromiumAndroidPort has.
Comment 3 WebKit Review Bot 2012-11-30 11:01:39 PST 
Attachment 176996 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:725:  indentation is not a multiple of four  [pep8/E111] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Peter Beverloo 2012-11-30 11:03:48 PST 
Created attachment 176997 [details]
Patch
Comment 5 Peter Beverloo 2012-11-30 11:04:50 PST 
(In reply to comment #3)
> If any of these errors are false positives, please file a bug against check-webkit-style.

webkit-patch check-style-local was clean :/. Something is really wrong with my local checkout, I'm going to fix that on Monday.
Comment 6 Eric Seidel (no email) 2012-11-30 11:07:51 PST 
Comment on attachment 176997 [details]
Patch

Looks reasonable.
Comment 7 Dirk Pranke 2012-11-30 12:07:23 PST 
looks reasonable to me as well.
Comment 8 Peter Beverloo 2012-12-04 07:56:52 PST 
Comment on attachment 176997 [details]
Patch

Forgot to set cq?/+. Thanks for the review guys!
Comment 9 WebKit Review Bot 2012-12-04 08:26:17 PST 
Comment on attachment 176997 [details]
Patch

Clearing flags on attachment: 176997

Committed r136510: <http://trac.webkit.org/changeset/136510>
Comment 10 WebKit Review Bot 2012-12-04 08:26:20 PST 
All reviewed patches have been landed.  Closing bug.