Bug 103748 - [BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry
Summary: [BlackBerry] Adding checks for null when checking cookie status in CookieJarB...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 07:47 PST by otcheung
Modified: 2012-12-02 12:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2012-11-30 07:50 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2012-11-30 07:57 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2012-11-30 08:33 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (1.63 KB, patch)
2012-12-02 10:42 PST, otcheung 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-11-30 07:47:42 PST 
Adding checks for null when checking cookie status in CookieJarBlackBerry
Comment 1 otcheung 2012-11-30 07:50:36 PST 
Created attachment 176967 [details]
Patch
Comment 2 otcheung 2012-11-30 07:57:57 PST 
Created attachment 176970 [details]
Patch
Comment 3 Rob Buis 2012-11-30 08:08:33 PST 
Comment on attachment 176970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176970&action=review

> Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp:51
> +    if (!(document && document->settings() && document->settings()->cookieEnabled()))

Looks like you can reuse cookiesEnabled.
Comment 4 otcheung 2012-11-30 08:33:43 PST 
Created attachment 176974 [details]
Patch
Comment 5 Rob Buis 2012-11-30 08:49:41 PST 
Comment on attachment 176974 [details]
Patch

LGTM.
Comment 6 WebKit Review Bot 2012-12-02 02:28:26 PST 
Comment on attachment 176974 [details]
Patch

Clearing flags on attachment: 176974

Committed r136321: <http://trac.webkit.org/changeset/136321>
Comment 7 WebKit Review Bot 2012-12-02 02:28:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 otcheung 2012-12-02 10:42:22 PST 
Reopening to attach new patch.
Comment 9 otcheung 2012-12-02 10:42:24 PST 
Created attachment 177142 [details]
Patch
Comment 10 Rob Buis 2012-12-02 12:26:34 PST 
Comment on attachment 177142 [details]
Patch

LGTM.
Comment 11 WebKit Review Bot 2012-12-02 12:30:07 PST 
Comment on attachment 177142 [details]
Patch

Clearing flags on attachment: 177142

Committed r136350: <http://trac.webkit.org/changeset/136350>
Comment 12 WebKit Review Bot 2012-12-02 12:30:10 PST 
All reviewed patches have been landed.  Closing bug.