Bug 103724 - Port SharedTimerWin.cpp to WinCE
Summary: Port SharedTimerWin.cpp to WinCE
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Other
: P2 Normal
Assignee: Patrick R. Gansterer
Depends on:
Reported: 2012-11-30 01:52 PST by Patrick R. Gansterer
Modified: 2013-01-30 03:59 PST (History)
3 users (show)

See Also:

Patch (10.59 KB, patch)
2012-11-30 01:56 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (10.63 KB, patch)
2013-01-29 13:54 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-11-30 01:52:12 PST
Port SharedTimerWin.cpp to WinCE
Comment 1 Patrick R. Gansterer 2012-11-30 01:56:50 PST
Created attachment 176926 [details]
Comment 2 Brent Fulgham 2012-12-06 12:15:29 PST
Comment on attachment 176926 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=176926&action=review

Looks good to me. r=me.

> Source/WebCore/platform/win/SharedTimerWin.cpp:133
> +#if OS(WINCE)

It's too bad these have to be different. I guess there's not much choice here, since the API doesn't existing in WinCE.

> Source/WebCore/platform/win/SharedTimerWin.cpp:227
> +#if !OS(WINCE)

This conditional would be unnecessary if you declared timer outside your earlier !OS(WINCE) declarations at top.
Comment 3 Patrick R. Gansterer 2013-01-29 13:54:06 PST
Created attachment 185302 [details]
Comment 4 WebKit Review Bot 2013-01-30 03:59:40 PST
Comment on attachment 185302 [details]

Clearing flags on attachment: 185302

Committed r141248: <http://trac.webkit.org/changeset/141248>
Comment 5 WebKit Review Bot 2013-01-30 03:59:44 PST
All reviewed patches have been landed.  Closing bug.