WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103724
Port SharedTimerWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=103724
Summary
Port SharedTimerWin.cpp to WinCE
Patrick R. Gansterer
Reported
2012-11-30 01:52:12 PST
Port SharedTimerWin.cpp to WinCE
Attachments
Patch
(10.59 KB, patch)
2012-11-30 01:56 PST
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Patch
(10.63 KB, patch)
2013-01-29 13:54 PST
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2012-11-30 01:56:50 PST
Created
attachment 176926
[details]
Patch
Brent Fulgham
Comment 2
2012-12-06 12:15:29 PST
Comment on
attachment 176926
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=176926&action=review
Looks good to me. r=me.
> Source/WebCore/platform/win/SharedTimerWin.cpp:133 > +#if OS(WINCE)
It's too bad these have to be different. I guess there's not much choice here, since the API doesn't existing in WinCE.
> Source/WebCore/platform/win/SharedTimerWin.cpp:227 > +#if !OS(WINCE)
This conditional would be unnecessary if you declared timer outside your earlier !OS(WINCE) declarations at top.
Patrick R. Gansterer
Comment 3
2013-01-29 13:54:06 PST
Created
attachment 185302
[details]
Patch
WebKit Review Bot
Comment 4
2013-01-30 03:59:40 PST
Comment on
attachment 185302
[details]
Patch Clearing flags on attachment: 185302 Committed
r141248
: <
http://trac.webkit.org/changeset/141248
>
WebKit Review Bot
Comment 5
2013-01-30 03:59:44 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug