Bug 103715 - Rationalize and clean up DFG handling of scoped accesses
Summary: Rationalize and clean up DFG handling of scoped accesses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 00:03 PST by Filip Pizlo
Modified: 2012-11-30 13:57 PST (History)
7 users (show)

See Also:

Attachments
work in progress (26.70 KB, patch)
2012-11-30 00:06 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (28.57 KB, patch)
2012-11-30 03:28 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-30 00:03:46 PST 
We use GetScope with a scope count even in places where the base is known (put_to_base), and the scope count eliminates CSE opportunities for code that accesses variables at different scope depths.  Also the code could just be simplified.
Comment 1 Filip Pizlo 2012-11-30 00:06:56 PST 
Created attachment 176907 [details]
work in progress

Still testing it.
Comment 2 Filip Pizlo 2012-11-30 03:28:07 PST 
Created attachment 176935 [details]
the patch
Comment 3 Filip Pizlo 2012-11-30 13:57:27 PST 
Landed in http://trac.webkit.org/changeset/136276