103712 – [Mac] [WK2] Safari shows empty window and paints webpage in full-screen background

Bug 103712 - [Mac] [WK2] Safari shows empty window and paints webpage in full-screen background

Summary: [Mac] [WK2] Safari shows empty window and paints webpage in full-screen backg...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit2 (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Jer Noble

URL:
Keywords:	InRadar, PlatformOnly

Depends on:
Blocks:

Reported:	2012-11-29 22:52 PST by Jer Noble
Modified:	2013-02-25 22:50 PST (History)
CC List:	10 users (show)

See Also:

Attachments
Patch (2.03 KB, patch) 2012-11-29 23:03 PST, Jer Noble	darin: review+ buildbot: commit-queue-	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jer Noble 2012-11-29 22:52:40 PST

Safari shows empty window and paints webpage in full-screen background

Comment 1 Jer Noble 2012-11-29 22:53:20 PST

<rdar://problem/12690288>

Comment 2 Jer Noble 2012-11-29 23:03:10 PST

Created attachment 176903 [details]
Patch

Comment 3 Build Bot 2013-01-16 06:42:23 PST

Comment on attachment 176903 [details]
Patch

Attachment 176903 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15912322

New failing tests:
svg/custom/bug86119.html
dom/xhtml/level3/core/canonicalform09.xhtml
fast/loader/redirect-with-open-subframe-2.html
fast/events/page-scaled-mouse-click-iframe.html
fast/xsl/xslt-missing-namespace-in-xslt.xml
dom/xhtml/level3/core/canonicalform08.xhtml
http/tests/security/contentSecurityPolicy/xsl-img-blocked.php

Comment 4 Jer Noble 2013-02-25 15:40:58 PST

Committed r143981: <http://trac.webkit.org/changeset/143981>

Comment 5 Csaba Osztrogonác 2013-02-25 22:11:55 PST

(In reply to comment #4)
> Committed r143981: <http://trac.webkit.org/changeset/143981>

It made many tests crash on WK2 platforms:
- Apple Mac WK2: http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20%28Tests%29/r143982%20%288244%29/results.html
- EFL: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/r143983%20%284570%29/results.html
- GTK: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/r143983%20%284570%29/results.html
- Qt: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r143982%20%2814262%29/results.html

Could you check and fix this regression?

Comment 6 Ryosuke Niwa 2013-02-25 22:15:53 PST

Comment on attachment 176903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176903&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:410
> +    if (m_frame->coreFrame()->document()->documentElement()->containsFullScreenElement())

We certainly need a null pointer check for documentElement()?

Comment 7 Jer Noble 2013-02-25 22:37:51 PST

I'm looking into this.

Comment 8 Jer Noble 2013-02-25 22:50:18 PST

Filed: https://bugs.webkit.org/show_bug.cgi?id=110848