Bug 103701 – REGRESSION(r136167): Win debug build failure (Requested by zhenyao on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/136167 broke the build:
Win debug build failure (Requested by zhenyao on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 176880 [details]
ROLLOUT of r136167

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Review Bot]

Comment on attachment 176880 [details]
ROLLOUT of r136167

Clearing flags on attachment: 176880

Committed r136196: <http://trac.webkit.org/changeset/136196>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Hin-Chung Lam]

Is there any log of the build failure?

[Min Qin]

sth like this:

169>  GraphicsContext3DPrivate.cpp
169>Link:
169>     Creating library ..\..\..\..\..\build\Debug\lib\webkit.lib
and object ..\..\..\..\..\build\Debug\lib\webkit.exp
169>webcore_platform.lib(LazyDecodingPixelRef.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __thiscall skia::LazyPixelRef::~LazyPixelRef(void)" (__imp_??1LazyPixelRef@skia@@UAE@XZ) referenced in function __unwindfunclet$??0LazyDecodingPixelRef@WebCore@@QAE@V?$PassRefPtr@VImageFrameGenerator@WebCore@@@WTF@@ABU?$SkTSize@H@@ABUSkIRect@@@Z$0
169>webcore_platform.lib(LazyDecodingPixelRef.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall skia::LazyPixelRef::LazyPixelRef(void)" (__imp_??0LazyPixelRef@skia@@QAE@XZ) referenced in function "public:__thiscall WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef(class WTF::PassRefPtr<class WebCore::ImageFrameGenerator>,struct SkTSize<int> const &,struct SkIRect const &)" (??0LazyDecodingPixelRef@WebCore@@QAE@V?$PassRefPtr@VImageFrameGenerator@WebCore@@@WTF@@ABU?$SkTSize@H@@ABUSkIRect@@@Z)
169>..\..\..\..\..\build\Debug\webkit.dll : fatal error LNK1120: 2 unresolved externals
169>
169>Build FAILED.

I submitted https://codereview.chromium.org/11299277/ to add ctor and dtor to lazy_pixel_ref.h, hope it solves the problem

(In reply to comment #4)
> Is there any log of the build failure?

[Hin-Chung Lam]

Cool alright.